more robust setup.py

Author: nschloe

pygalmesh/__init__.py

@@ -22,7 +22,7 @@
 )
 
 from . import _cli
-from .__about__ import __version__, __cgal_version__
+from .__about__ import __cgal_version__, __version__
 from .main import (
     generate_2d,
     generate_from_array,

setup.cfg

@@ -31,12 +31,12 @@ keywords =
 
 [options]
 packages = find:
-setup_requires = pybind11 >= 2.2
+setup_requires = pybind11 >= 2.5
 install_requires =
     importlib_metadata;python_version<"3.8"
     meshio >= 4.0.0, < 5.0.0
     numpy
-    pybind11 >= 2.2
+    pybind11 >= 2.5
 python_requires = >=3.6
 
 [options.entry_points]

setup.py

@@ -1,52 +1,126 @@
 import os
+import sys
 
+import setuptools
 from setuptools import Extension, setup
+from setuptools.command.build_ext import build_ext
 
 
-class get_pybind_include:
-    """Helper class to determine the pybind11 include path. The purpose of this class is
-    to postpone importing pybind11 until it is actually installed, so that the
-    ``get_include()`` method can be invoked.
-    """
-
-    def __init__(self, user=False):
-        self.user = user
+# <https://github.com/pybind/python_example/blob/master/setup.py>
+class get_pybind_include(object):
+    """Helper class to determine the pybind11 include path
+    The purpose of this class is to postpone importing pybind11
+    until it is actually installed, so that the ``get_include()``
+    method can be invoked."""
 
     def __str__(self):
         import pybind11
 
-        return pybind11.get_include(self.user)
+        return pybind11.get_include()
+
+
+# cf http://bugs.python.org/issue26689
+def has_flag(compiler, flagname):
+    """Return a boolean indicating whether a flag name is supported on
+    the specified compiler.
+    """
+    import os
+    import tempfile
+
+    with tempfile.NamedTemporaryFile("w", suffix=".cpp", delete=False) as f:
+        f.write("int main (int argc, char **argv) { return 0; }")
+        fname = f.name
+    try:
+        compiler.compile([fname], extra_postargs=[flagname])
+    except setuptools.distutils.errors.CompileError:
+        return False
+    finally:
+        try:
+            os.remove(fname)
+        except OSError:
+            pass
+    return True
+
+
+def cpp_flag(compiler):
+    """Return the -std=c++[11/14/17] compiler flag.
+    The newer version is prefered over c++11 (when it is available).
+    """
+    flags = ["-std=c++17", "-std=c++14", "-std=c++11"]
+
+    for flag in flags:
+        if has_flag(compiler, flag):
+            return flag
+
+    raise RuntimeError("Unsupported compiler -- at least C++11 support " "is needed!")
+
+
+class BuildExt(build_ext):
+    """A custom build extension for adding compiler-specific options."""
+
+    c_opts = {
+        "msvc": ["/EHsc"],
+        "unix": [],
+    }
+    l_opts = {
+        "msvc": [],
+        "unix": [],
+    }
+
+    if sys.platform == "darwin":
+        darwin_opts = ["-stdlib=libc++", "-mmacosx-version-min=10.7"]
+        c_opts["unix"] += darwin_opts
+        l_opts["unix"] += darwin_opts
+
+    def build_extensions(self):
+        ct = self.compiler.compiler_type
+        opts = self.c_opts.get(ct, [])
+        link_opts = self.l_opts.get(ct, [])
+        if ct == "unix":
+            opts.append(cpp_flag(self.compiler))
+            if has_flag(self.compiler, "-fvisibility=hidden"):
+                opts.append("-fvisibility=hidden")
+
+        for ext in self.extensions:
+            ext.define_macros = [
+                ("VERSION_INFO", '"{}"'.format(self.distribution.get_version()))
+            ]
+            ext.extra_compile_args = opts
+            ext.extra_link_args = link_opts
+        build_ext.build_extensions(self)
 
 
 ext_modules = [
     Extension(
         "_pygalmesh",
-        [
-            "src/generate.cpp",
-            "src/generate_2d.cpp",
-            "src/generate_from_inr.cpp",
-            "src/generate_from_off.cpp",
-            "src/generate_periodic.cpp",
-            "src/generate_surface_mesh.cpp",
-            "src/remesh_surface.cpp",
-            "src/version.cpp",
-            "src/pybind11.cpp",
-        ],
-        language="c++",
+        # Sort input source files to ensure bit-for-bit reproducible builds
+        # (https://github.com/pybind/python_example/pull/53)
+        sorted(
+            [
+                "src/generate.cpp",
+                "src/generate_2d.cpp",
+                "src/generate_from_inr.cpp",
+                "src/generate_from_off.cpp",
+                "src/generate_periodic.cpp",
+                "src/generate_surface_mesh.cpp",
+                "src/remesh_surface.cpp",
+                "src/pybind11.cpp",
+            ]
+        ),
         include_dirs=[
             os.environ.get("EIGEN_INCLUDE_DIR", "/usr/include/eigen3/"),
             # Path to pybind11 headers
             get_pybind_include(),
-            get_pybind_include(user=True),
         ],
-        extra_compile_args=["-std=c++14"],
+        language="c++",
         # no CGAL libraries necessary from CGAL 5.0 onwards
         libraries=["gmp", "mpfr"],
     )
 ]
 
 if __name__ == "__main__":
     setup(
-        # cmdclass={'build_ext': BuildExt},
+        cmdclass={"build_ext": BuildExt},
         ext_modules=ext_modules,
+        zip_safe=False,
     )