improve tests

Author: nschloe

test/test_inr.py

@@ -1,4 +1,3 @@
-import os
 import pathlib
 import tempfile
 
@@ -13,19 +12,18 @@ def test_inr():
     # mesh = pygalmesh.generate_from_inr(
     #     this_dir / "meshes" / "skull_2.9.inr", cell_size=5.0, verbose=False
     # )
-    fh, vtk_filename = tempfile.mkstemp(suffix=".vtk")
-    os.close(fh)
-    pygalmesh._cli.inr(
-        [
-            str(this_dir / "meshes" / "skull_2.9.inr"),
-            vtk_filename,
-            "--cell-size",
-            "5.0",
-            "--quiet",
-        ]
-    )
-    mesh = meshio.read(vtk_filename)
-    os.remove(vtk_filename)
+    with tempfile.TemporaryDirectory() as tmp:
+        out_filename = str(pathlib.Path(tmp) / "out.vtk")
+        pygalmesh._cli.inr(
+            [
+                str(this_dir / "meshes" / "skull_2.9.inr"),
+                out_filename,
+                "--cell-size",
+                "5.0",
+                "--quiet",
+            ]
+        )
+        mesh = meshio.read(out_filename)
 
     tol = 2.0e-3
     ref = [2.031053e02, 3.739508e01, 2.425594e02, 2.558910e01, 2.300883e02, 1.775010e00]

test/test_remesh_surface.py

@@ -1,4 +1,3 @@
-import os
 import pathlib
 import tempfile
 
@@ -18,25 +17,24 @@ def test_inr():
     #     facet_distance=0.001,
     #     verbose=False,
     # )
-    fh, out_filename = tempfile.mkstemp(suffix=".vtk")
-    os.close(fh)
-    pygalmesh._cli.remesh_surface(
-        [
-            str(this_dir / "meshes" / "lion-head.off"),
-            out_filename,
-            "--edge-size",
-            "0.025",
-            "--facet-angle",
-            "25",
-            "--facet-size",
-            "0.1",
-            "--facet-distance",
-            "0.001",
-            "--quiet",
-        ]
-    )
-    mesh = meshio.read(out_filename)
-    os.remove(out_filename)
+    with tempfile.TemporaryDirectory() as tmp:
+        out_filename = str(pathlib.Path(tmp) / "out.vtk")
+        pygalmesh._cli.remesh_surface(
+            [
+                str(this_dir / "meshes" / "lion-head.off"),
+                out_filename,
+                "--edge-size",
+                "0.025",
+                "--facet-angle",
+                "25",
+                "--facet-size",
+                "0.1",
+                "--facet-distance",
+                "0.001",
+                "--quiet",
+            ]
+        )
+        mesh = meshio.read(out_filename)
 
     tol = 1.0e-3
     ref = [

test/test_volume_from_surface.py

@@ -1,4 +1,3 @@
-import os
 import pathlib
 import tempfile
 
@@ -18,25 +17,24 @@ def test_volume_from_surface():
     #     cell_radius_edge_ratio=3.0,
     #     verbose=False,
     # )
-    fh, out_filename = tempfile.mkstemp(suffix=".vtk")
-    os.close(fh)
-    pygalmesh._cli.volume_from_surface(
-        [
-            str(this_dir / "meshes" / "elephant.vtu"),
-            out_filename,
-            "--facet-angle",
-            "0.5",
-            "--facet-size",
-            "0.15",
-            "--facet-distance",
-            "0.008",
-            "--cell-radius-edge-ratio",
-            "3.0",
-            "--quiet",
-        ]
-    )
-    mesh = meshio.read(out_filename)
-    os.remove(out_filename)
+    with tempfile.TemporaryDirectory() as tmp:
+        out_filename = str(pathlib.Path(tmp) / "out.vtk")
+        pygalmesh._cli.volume_from_surface(
+            [
+                str(this_dir / "meshes" / "elephant.vtu"),
+                out_filename,
+                "--facet-angle",
+                "0.5",
+                "--facet-size",
+                "0.15",
+                "--facet-distance",
+                "0.008",
+                "--cell-radius-edge-ratio",
+                "3.0",
+                "--quiet",
+            ]
+        )
+        mesh = meshio.read(out_filename)
 
     tol = 2.0e-2
     assert abs(max(mesh.points[:, 0]) - 0.357612477657) < tol