fix(geofence): gate foreign-geofence Edit on connection; test cleanup

Address CodeRabbit review on #6117:
- WaypointInfoDialog's Edit button now requires `isConnected` in both map
  flavors — editing a foreign geofence re-broadcasts it, which needs a live
  connection, so the affordance is hidden when offline.
- MeshDataHandlerTest uses FakeNotificationPrefs instead of a hand-stubbed mock.
- Add a NotificationPrefs test for retoggle-refreshes-eviction-order on the
  capped opt-in set.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: jamesarich

androidApp/src/fdroid/kotlin/org/meshtastic/app/map/MapView.kt

@@ -833,9 +833,10 @@ fun MapView(
             alertsEnabled = waypoint.id in optIns,
             onToggleAlerts = { mapViewModel.setGeofenceAlertOptIn(waypoint.id, it) },
             onDismissRequest = { showGeofenceInfoDialog = null },
-            // Unlocked foreign geofences can still be edited/re-broadcast; locked ones stay read-only.
+            // Unlocked foreign geofences can still be edited/re-broadcast (only while connected, since editing means
+            // re-sending); locked ones stay read-only.
             onEdit =
-            if (waypoint.locked_to == 0) {
+            if (waypoint.locked_to == 0 && isConnected) {
                 {
                     showGeofenceInfoDialog = null
                     showEditWaypointDialog = waypoint

androidApp/src/google/kotlin/org/meshtastic/app/map/MapView.kt

@@ -731,9 +731,10 @@ fun MapView(
                     alertsEnabled = waypoint.id in optIns,
                     onToggleAlerts = { mapViewModel.setGeofenceAlertOptIn(waypoint.id, it) },
                     onDismissRequest = { geofenceInfoWaypoint = null },
-                    // Unlocked foreign geofences can still be edited/re-broadcast; locked ones stay read-only.
+                    // Unlocked foreign geofences can still be edited/re-broadcast (only while connected, since editing
+                    // means re-sending); locked ones stay read-only.
                     onEdit =
-                    if (waypoint.locked_to == 0) {
+                    if (waypoint.locked_to == 0 && isConnected) {
                         {
                             geofenceInfoWaypoint = null
                             editingWaypoint = waypoint

core/data/src/commonTest/kotlin/org/meshtastic/core/data/manager/MeshDataHandlerTest.kt

@@ -48,7 +48,6 @@ import org.meshtastic.core.repository.MessageFilter
 import org.meshtastic.core.repository.NeighborInfoHandler
 import org.meshtastic.core.repository.NodeManager
 import org.meshtastic.core.repository.NotificationManager
-import org.meshtastic.core.repository.NotificationPrefs
 import org.meshtastic.core.repository.PacketHandler
 import org.meshtastic.core.repository.PacketRepository
 import org.meshtastic.core.repository.PlatformAnalytics
@@ -57,6 +56,7 @@ import org.meshtastic.core.repository.ServiceRepository
 import org.meshtastic.core.repository.StoreForwardPacketHandler
 import org.meshtastic.core.repository.TelemetryPacketHandler
 import org.meshtastic.core.repository.TracerouteHandler
+import org.meshtastic.core.testing.FakeNotificationPrefs
 import org.meshtastic.proto.ChannelSet
 import org.meshtastic.proto.ChannelSettings
 import org.meshtastic.proto.Data
@@ -148,10 +148,7 @@ class MeshDataHandlerTest {
                     nodeManager = nodeManager,
                     serviceNotifications = serviceNotifications,
                     crossingStore = GeofenceCrossingStore(),
-                    notificationPrefs =
-                    mock<NotificationPrefs>(MockMode.autofill).apply {
-                        every { geofenceAlertOptIns } returns MutableStateFlow<Set<Int>>(emptySet())
-                    },
+                    notificationPrefs = FakeNotificationPrefs(),
                     scope = geofenceScope,
                 ),
                 meshBeaconRepository = meshBeaconRepository,

core/prefs/src/commonTest/kotlin/org/meshtastic/core/prefs/notification/NotificationPrefsTest.kt

@@ -116,4 +116,22 @@ class NotificationPrefsTest {
         assertFalse(2 in ids)
         assertTrue(max + 2 in ids) // newest kept
     }
+
+    @Test
+    fun `geofenceAlertOptIns retoggle refreshes eviction order`() = testScope.runTest {
+        val max = NotificationPrefsImpl.MAX_GEOFENCE_OPT_INS
+        (1..max).forEach { notificationPrefs.setGeofenceAlertOptIn(it, enabled = true) } // 1 = oldest
+
+        notificationPrefs.setGeofenceAlertOptIn(
+            1,
+            enabled = true,
+        ) // re-toggle → 1 becomes most-recent, 2 now oldest
+        notificationPrefs.setGeofenceAlertOptIn(max + 1, enabled = true) // forces one eviction
+
+        val ids = notificationPrefs.geofenceAlertOptIns.value
+        assertEquals(max, ids.size)
+        assertTrue(1 in ids) // retoggled id survived
+        assertFalse(2 in ids) // 2 became the oldest and was evicted
+        assertTrue(max + 1 in ids)
+    }
 }