fix(firmware): accept older local firmware filename shapes

Allow target followed by a firmware marker segment (e.g.
heltec-v3-firmware-2.7.17.bin, heltec-v3.firmware.bin) in
addition to the standard release-style names. The regex now
accepts target + delimiter + (version | firmware) as a valid
continuation, while still rejecting target-prefix collisions like
tbeam vs tbeam-s3-core.

Author: jeremiah-k

feature/firmware/src/commonMain/kotlin/org/meshtastic/feature/firmware/FirmwareFileHandler.kt

@@ -129,7 +129,7 @@ internal fun isValidFirmwareFile(filename: String, target: String, fileExtension
 
     val targetToken = Regex.escape(target)
     val extensionToken = Regex.escape(fileExtension)
-    val targetPattern = Regex("(^|.*[\\-_])$targetToken(([\\-_.]v?\\d).*$extensionToken$|$extensionToken$)")
+    val targetPattern = Regex("(^|.*[\\-_])$targetToken(([\\-_.](v?\\d|firmware)).*$extensionToken$|$extensionToken$)")
     return targetPattern.matches(filename)
 }
 

feature/firmware/src/commonTest/kotlin/org/meshtastic/feature/firmware/IsValidFirmwareFileTest.kt

@@ -123,6 +123,17 @@ class IsValidFirmwareFileTest {
         assertTrue(isValidFirmwareFile("firmware-nano-g1-explorer-2.8.0.bin", "nano-g1-explorer", ".bin"))
     }
 
+    @Test
+    fun `accepts older local firmware filename shapes`() {
+        // Older naming where "firmware" appears as a segment after the target.
+        assertTrue(isValidFirmwareFile("heltec-v3-firmware-2.7.17.bin", "heltec-v3", ".bin"))
+        assertTrue(isValidFirmwareFile("heltec-v3.firmware.bin", "heltec-v3", ".bin"))
+        // Standard release names still work.
+        assertTrue(isValidFirmwareFile("firmware-heltec-v3-2.7.17.bin", "heltec-v3", ".bin"))
+        assertTrue(isValidFirmwareFile("heltec-v3-2.7.17.bin", "heltec-v3", ".bin"))
+        assertTrue(isValidFirmwareFile("heltec-v3.bin", "heltec-v3", ".bin"))
+    }
+
     // ── Edge cases ──────────────────────────────────────────────────────────
 
     @Test