refactor(ui): remove StatusSurface scrim behind status-colored chips (#6367)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Author: jamesarich

core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/NodeItem.kt

@@ -284,8 +284,8 @@ private fun NodeBatteryPositionRow(
 @Suppress("CyclomaticComplexMethod", "LongMethod")
 @Composable
 private fun NodeSignalRow(thatNode: Node, isThisNode: Boolean, contentColor: Color) {
-    // The signal pill bundles SNR + RSSI + quality into one scrim-backed chip (legibility, see StatusSurface). It's
-    // wider than a 1/3 grid cell, so it renders on its own line at natural width; the short metrics flow in the grid.
+    // The signal pill bundles SNR + RSSI + quality into one row. It's wider than a 1/3 grid cell, so it renders on
+    // its own line at natural width; the short metrics flow in the grid.
     var signalChip: (@Composable () -> Unit)? = null
     val items =
         buildList<@Composable () -> Unit> {
@@ -316,10 +316,10 @@ private fun NodeSignalRow(thatNode: Node, isThisNode: Boolean, contentColor: Col
                     val showRssi = thatNode.rssi < 0
                     if (showSnr || showRssi) {
                         signalChip = {
-                            // Full-width pill: SNR left, RSSI center, quality right — the pre-scrim spread, now
-                            // scrimmed.
-                            StatusSurface(
+                            // Full-width row: SNR left, RSSI center, quality right.
+                            Row(
                                 modifier = Modifier.fillMaxWidth(),
+                                verticalAlignment = Alignment.CenterVertically,
                                 horizontalArrangement = Arrangement.SpaceBetween,
                             ) {
                                 if (showSnr) Snr(thatNode.snr)
@@ -448,29 +448,27 @@ private fun MetricsGrid(items: List<@Composable () -> Unit>) {
 }
 
 /**
- * [LastHeardInfo] backed by a scrim chip and tinted StatusGreen when [online] — the legible "online" affordance —
- * rendered plain otherwise. Shared by the complete and compact node rows.
+ * [LastHeardInfo] tinted StatusGreen when [online] — the "online" affordance — rendered plain otherwise. Shared by the
+ * complete and compact node rows.
  */
 @Composable
 internal fun StatusAwareLastHeard(lastHeard: Int, online: Boolean, contentColor: Color, relative: Boolean = true) {
-    if (online) {
-        StatusSurface {
-            LastHeardInfo(
-                lastHeard = lastHeard,
-                showLabel = false,
-                relative = relative,
-                contentColor = MaterialTheme.colorScheme.StatusGreen,
-            )
-        }
-    } else {
-        LastHeardInfo(lastHeard = lastHeard, showLabel = false, relative = relative, contentColor = contentColor)
-    }
+    LastHeardInfo(
+        lastHeard = lastHeard,
+        showLabel = false,
+        relative = relative,
+        contentColor = if (online) MaterialTheme.colorScheme.StatusGreen else contentColor,
+    )
 }
 
-/** Key status (always status-colored) + the signed-node shield share one scrim chip so both stay legible. */
+/** Key status (always status-colored) + the signed-node shield. */
 @Composable
 fun NodeSecurityIcons(thatNode: Node, modifier: Modifier = Modifier, iconSize: Dp = 20.dp) {
-    StatusSurface(modifier = modifier) {
+    Row(
+        modifier = modifier,
+        verticalAlignment = Alignment.CenterVertically,
+        horizontalArrangement = Arrangement.spacedBy(4.dp),
+    ) {
         if (thatNode.signsPackets) {
             NodeSignedStatusIcon(modifier = Modifier.size(iconSize))
         }

core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/NodeItemCompact.kt

@@ -356,14 +356,12 @@ private fun CompactHealthRow(
             val quality = determineSignalQuality(thatNode.snr, LocalModemPreset.current)
             add(
                 @Composable {
-                    StatusSurface {
-                        IconInfo(
-                            icon = vectorResource(quality.icon),
-                            contentDescription = stringResource(quality.nameRes),
-                            contentColor = quality.color.invoke(),
-                            text = stringResource(quality.nameRes),
-                        )
-                    }
+                    IconInfo(
+                        icon = vectorResource(quality.icon),
+                        contentDescription = stringResource(quality.nameRes),
+                        contentColor = quality.color.invoke(),
+                        text = stringResource(quality.nameRes),
+                    )
                 },
             )
         }

core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/StatusSurface.kt

@@ -23,7 +23,6 @@ import androidx.compose.foundation.layout.Arrangement
 import androidx.compose.foundation.layout.Box
 import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.IntrinsicSize
-import androidx.compose.foundation.layout.PaddingValues
 import androidx.compose.foundation.layout.Row
 import androidx.compose.foundation.layout.Spacer
 import androidx.compose.foundation.layout.fillMaxWidth
@@ -79,7 +78,6 @@ import org.meshtastic.core.ui.component.NODE_TINT_NORMAL
 import org.meshtastic.core.ui.component.NodeChip
 import org.meshtastic.core.ui.component.Rssi
 import org.meshtastic.core.ui.component.Snr
-import org.meshtastic.core.ui.component.StatusSurface
 import org.meshtastic.core.ui.component.TransportIcon
 import org.meshtastic.core.ui.component.nodeBorderStroke
 import org.meshtastic.core.ui.component.nodeTintedContainer
@@ -329,21 +327,16 @@ fun MessageItem(
                     if (!message.fromLocal) {
                         // XEdDSA is only set on verified broadcasts, never DMs — so this never shows on a DM.
                         if (message.xeddsaSigned) {
-                            // Solo icon → equal padding so the pill renders as a circle.
-                            StatusSurface(contentPadding = PaddingValues(3.dp)) {
-                                Icon(
-                                    imageVector = MeshtasticIcons.ShieldCheck,
-                                    contentDescription = stringResource(Res.string.security_signed_verified),
-                                    modifier = Modifier.size(16.dp),
-                                    tint = MaterialTheme.colorScheme.StatusGreen,
-                                )
-                            }
+                            Icon(
+                                imageVector = MeshtasticIcons.ShieldCheck,
+                                contentDescription = stringResource(Res.string.security_signed_verified),
+                                modifier = Modifier.size(16.dp),
+                                tint = MaterialTheme.colorScheme.StatusGreen,
+                            )
                         }
                         if (message.hopsAway == 0 && !message.viaMqtt) {
-                            StatusSurface {
-                                Snr(message.snr)
-                                Rssi(message.rssi)
-                            }
+                            Snr(message.snr)
+                            Rssi(message.rssi)
                         } else {
                             Row(
                                 verticalAlignment = Alignment.CenterVertically,