Docs pre-release cleanup + fix documentation translation pipeline (#1963)

* docs: remove the pre-release banner and --beta build flag entirely

The in-app and website docs carried a 'Pre-release — subject to change'
banner injected by build-docs.sh's --beta flag, mirrored by a runtime banner
in MarkdownConverter for translated pages, and guarded at release time by a
dedicated cut-release/release-gate dance. The banner is no longer wanted.

- build-docs.sh: drop the --beta flag and banner injection
- MarkdownConverter: drop the runtime banner from wrapInHTMLDocument /
  wrapInHTMLDocumentForFile / rewrapForFile (callers passed no banner arg)
- docs.css: remove the now-unused .pre-release-banner class
- docs-deploy.yml: build without --beta; delete the obsolete
  docs-release-gate.yml (its only job was blocking a banner leak)
- cut-release-docs.sh / RELEASING / contributing / copilot-instructions /
  constitution: drop --beta references and the release-gate workflow row
- specs: fix --beta build commands; mark specs/013 (the banner release-
  versioning feature) Superseded and note the removal in specs/003 FRs
- remove an orphaned built page (adding-locale-translations.html) that had
  no source markdown and still carried the banner
- rebuild the in-app HTML bundle

Build succeeds for the iOS simulator.

* fix: docs translation language detection and stop caching untranslated English

Two related docs-translation bugs:

1. Language detection used Locale.current, which reflects the device REGION
   locale, not the app's display language. With a per-app language override
   (iOS Settings > App > Language) the UI localizes via preferredLocalizations
   while Locale.current stays on the device region — so the app could be fully
   Spanish yet the docs pipeline saw "en" and never translated. Detect the
   docs language from Bundle.main.documentationLanguageCode (the resolved
   display localization) instead, across all call sites.

2. translateMarkdown silently fell back to the English source per segment when
   no translation backend was available (Apple Translation language pack not
   installed AND FoundationModels unavailable), then cached and even uploaded
   that English as a completed translation — polluting the on-device cache and
   the community translations repo. Gate translateMarkdown on a real backend
   being available up front; return nil (skip) otherwise so nothing fake is
   cached or uploaded. The HTML path already behaved correctly.

* feat: prompt to download the language pack when docs translation is unavailable

When the docs language is supported by Apple Translation but the on-device
language pack isn't installed (and FoundationModels isn't available), the docs
previously just stayed English with no explanation. Add an in-context prompt:

- DocTranslationService.translationBackendStatus(for:) reports available /
  needsLanguagePack / unavailable.
- DocBrowserView shows a 'Translate Documentation' banner with a Download button
  when the pack is needed; tapping it runs a Translation framework
  prepareTranslation() download (LanguagePackDownloadModifier), then re-runs the
  pipeline so the docs translate in-session.
- kickoffTranslation() also reloads DocBundle after on-device prefetch builds the
  rendered folder, so on-device translations appear without a cold relaunch.

Compiled to a no-op on Mac Catalyst / pre-iOS 26 where the Translation framework
is unavailable.

Author: garthvh

.github/copilot-instructions.md

@@ -195,7 +195,7 @@ The app ships a complete offline documentation system (feature `003-app-docs-mar
   - The `**` closing the title must be immediately adjacent to the last word (no trailing space): `> **Tip — Title**` ✓, `> **Tip — Title **` ✗.
 - **After editing any `.md` file under `docs/`**, regenerate the bundled HTML and commit it:
   ```bash
-  bash scripts/build-docs.sh --output Meshtastic/Resources/docs --beta
+  bash scripts/build-docs.sh --output Meshtastic/Resources/docs
   ```
   Then copy updated snapshots if needed:
   ```bash

.github/workflows/docs-deploy.yml

@@ -81,7 +81,7 @@ jobs:
         run: sudo apt-get install -y cmark-gfm
 
       - name: Build docs bundle
-        run: bash scripts/build-docs.sh --output Meshtastic/Resources/docs --beta
+        run: bash scripts/build-docs.sh --output Meshtastic/Resources/docs
 
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1

.github/workflows/docs-release-gate.yml

@@ -89,7 +89,7 @@ jobs:
               '',
               'If this PR does **not** require a doc update (e.g., internal refactor, bug fix, test change), add the **`skip-docs-check`** label to dismiss this warning.',
               '',
-              'After updating `docs/`, re-run `bash scripts/build-docs.sh --output Meshtastic/Resources/docs --beta` locally and commit the regenerated HTML bundle.',
+              'After updating `docs/`, re-run `bash scripts/build-docs.sh --output Meshtastic/Resources/docs` locally and commit the regenerated HTML bundle.',
             ].join('\n');
 
             // Find and update an existing bot comment, or create a new one

.github/workflows/docs-staleness.yml

@@ -9,7 +9,7 @@ Sync Impact Report
       in-app and on the website — using the shared
       `**Month YYYY** — [Page](path.md) — sentence` format showing ~12 months;
       docs/index.md is a Quick Links hub; no release notes / RELEASENOTES.md;
-      rebuild in-app HTML with `--beta`
+      rebuild in-app HTML after editing docs
   Added sections: none
   Removed sections: N/A
   Templates requiring updates:
@@ -219,9 +219,8 @@ cross-platform consistency as standards evolve.
   The website home `docs/index.md` is a Quick Links nav hub (no changelog),
   and the guide landings `docs/user.md` / `docs/developer.md` link to their
   "What's New" child rather than duplicating it. After editing any in-app
-  doc, run `scripts/build-docs.sh --output Meshtastic/Resources/docs --beta`
-  to regenerate the bundled HTML under `Meshtastic/Resources/docs/` (the
-  `--beta` flag preserves the pre-release banner the repo ships with).
+  doc, run `scripts/build-docs.sh --output Meshtastic/Resources/docs`
+  to regenerate the bundled HTML under `Meshtastic/Resources/docs/`.
 
 ## Governance
 

.specify/memory/constitution.md

@@ -31,4 +31,17 @@ extension Bundle {
 		return false
 		#endif
 	}
+
+	/// The language the app is actually *displaying* in, normalized to a language code (e.g. "es").
+	///
+	/// Use this — not `Locale.current` — to decide the documentation translation target. A per-app
+	/// language override (iOS Settings → Meshtastic → Language) localizes the UI via
+	/// `preferredLocalizations` but leaves `Locale.current` reflecting the device's region locale,
+	/// so they disagree: the app can be fully Spanish while `Locale.current.language.languageCode`
+	/// is still "en". Keying docs translation off the display localization keeps docs in sync with
+	/// the chrome the user actually sees. Falls back to "en".
+	public var documentationLanguageCode: String {
+		let preferred = preferredLocalizations.first ?? "en"
+		return Locale(identifier: preferred).language.languageCode?.identifier ?? "en"
+	}
 }

Meshtastic/Extensions/Bundle.swift

@@ -349,13 +349,3 @@ picture img {
     margin-bottom: 6px;
     color: var(--warning-border);
 }
-
-/* ── Pre-release warning banner ── */
-.pre-release-banner {
-    background-color: var(--warning-bg);
-    border: 1px solid var(--warning-border);
-    border-radius: 6px;
-    padding: 10px 14px;
-    margin-bottom: 16px;
-    font-size: 0.875rem;
-}

Meshtastic/Resources/docs/assets/docs.css

@@ -45,7 +45,7 @@ <h2>Documentation</h2>
 </tbody>
 </table>
 <p>Source markdown lives under <code>docs/user/</code> and <code>docs/developer/</code>. To rebuild the bundled HTML after editing any markdown:</p>
-<pre><code class="language-sh">bash scripts/build-docs.sh --output Meshtastic/Resources/docs --beta
+<pre><code class="language-sh">bash scripts/build-docs.sh --output Meshtastic/Resources/docs
 </code></pre>
 <p>Commit the regenerated files under <code>Meshtastic/Resources/docs/</code> with your PR.</p>
 <h2>Branch Naming</h2>