Skip to content

Commit 7458a9d

Browse files
committed
fix(canned-messages): stop writing deprecated allow_input_source (#2022)
CannedMessageConfig saves derived and wrote the deprecated allowInputSource field (allow_input_source = 10) on every save. The field has been removed from active use upstream with no successor \u2014 the firmware derives the input source from the rotary1Enabled / updown1Enabled flags. - Stop writing cmc.allowInputSource on save. - No read-side change needed: the field was never persisted (absent from the SwiftData model and UpdateSwiftData), so values arriving from older firmware are already ignored without crashing.
1 parent e531f15 commit 7458a9d

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

Meshtastic/Views/Settings/Config/Module/CannedMessagesConfig.swift

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -188,13 +188,10 @@ struct CannedMessagesConfig: View {
188188
cmc.sendBell = sendBell
189189
cmc.rotary1Enabled = rotary1Enabled
190190
cmc.updown1Enabled = updown1Enabled
191-
if rotary1Enabled {
192-
cmc.allowInputSource = "rotEnc1"
193-
} else if updown1Enabled {
194-
cmc.allowInputSource = "upDown1"
195-
} else {
196-
cmc.allowInputSource = "_any"
197-
}
191+
// allow_input_source is deprecated with no successor — the input
192+
// source is governed by the rotary1Enabled / updown1Enabled flags
193+
// above. Intentionally not written; inbound values from older
194+
// firmware are ignored (never persisted). (#2022)
198195
cmc.inputbrokerPinA = UInt32(inputbrokerPinA)
199196
cmc.inputbrokerPinB = UInt32(inputbrokerPinB)
200197
cmc.inputbrokerPinPress = UInt32(inputbrokerPinPress)

0 commit comments

Comments
 (0)