Improve local stats noise floor chart (#1926)

* Improve local stats noise floor tooling

* Simplify local stats chart controls

* Add local stats screenshot

* Add local stats reading request to chart

* Move local stats request to action bar

* Compact local stats action labels

* Simplify local stats chart presentation

* Fix local stats chart axis clipping

* Fix local stats chart time label clipping

* Add copy actions to local stats fields

Author: RCGV1

Meshtastic/Persistence/PerformanceSeedData.swift

@@ -14,13 +14,16 @@ import Foundation
 struct PerformanceSeedConfiguration {
 	let nodeCount: Int
 	let telemetryHistoryPerNode: Int
+	let localStatsHistoryPerNode: Int
 	let positionHistoryPerNode: Int
 	let directMessageCount: Int
 	let channelMessageCount: Int
 	let resetStore: Bool
 	let compactNodeList: Bool
 	let disableDiscovery: Bool
 	let initialTab: NavigationState.Tab
+	let opensLocalStatsLog: Bool
+	let localStatsSameHourSeed: Bool
 }
 
 @MainActor
@@ -34,13 +37,16 @@ enum PerformanceSeedData {
 		return PerformanceSeedConfiguration(
 			nodeCount: integerValue("MESHTASTIC_PERF_SEED_NODES", environment: environment, defaultValue: 5_000),
 			telemetryHistoryPerNode: integerValue("MESHTASTIC_PERF_TELEMETRY_HISTORY", environment: environment, defaultValue: 3),
+			localStatsHistoryPerNode: integerValue("MESHTASTIC_PERF_LOCAL_STATS_HISTORY", environment: environment, defaultValue: integerValue("MESHTASTIC_PERF_TELEMETRY_HISTORY", environment: environment, defaultValue: 3)),
 			positionHistoryPerNode: integerValue("MESHTASTIC_PERF_POSITION_HISTORY", environment: environment, defaultValue: 3),
 			directMessageCount: integerValue("MESHTASTIC_PERF_DIRECT_MESSAGES", environment: environment, defaultValue: 0),
 			channelMessageCount: integerValue("MESHTASTIC_PERF_CHANNEL_MESSAGES", environment: environment, defaultValue: 0),
 			resetStore: boolValue("MESHTASTIC_PERF_RESET_STORE", environment: environment) || arguments.contains("--meshtastic-perf-reset"),
 			compactNodeList: boolValue("MESHTASTIC_PERF_COMPACT_LIST", environment: environment) || arguments.contains("--meshtastic-perf-compact-list"),
 			disableDiscovery: !boolValue("MESHTASTIC_PERF_ENABLE_DISCOVERY", environment: environment),
-			initialTab: arguments.contains("--meshtastic-perf-start-map") ? .map : .nodes
+			initialTab: arguments.contains("--meshtastic-perf-start-map") ? .map : .nodes,
+			opensLocalStatsLog: arguments.contains("--meshtastic-perf-start-local-stats"),
+			localStatsSameHourSeed: arguments.contains("--meshtastic-perf-local-stats-same-hour")
 		)
 	}
 
@@ -69,11 +75,14 @@ enum PerformanceSeedData {
 				try? context.save()
 			}
 			router.selectedTab = configuration.initialTab
+			if configuration.opensLocalStatsLog {
+				router.selectedNodeNum = 0x0A00_0000
+			}
 			Logger.data.info("📈 [PerfSeed] Existing large mesh seed found; skipping reseed")
 			return
 		}
 
-		Logger.data.info("📈 [PerfSeed] Seeding \(configuration.nodeCount, privacy: .public) nodes, \(configuration.telemetryHistoryPerNode, privacy: .public) telemetry samples/type, \(configuration.positionHistoryPerNode, privacy: .public) positions/node")
+		Logger.data.info("📈 [PerfSeed] Seeding \(configuration.nodeCount, privacy: .public) nodes, \(configuration.telemetryHistoryPerNode, privacy: .public) telemetry samples/type, \(configuration.localStatsHistoryPerNode, privacy: .public) local stats samples/node, \(configuration.positionHistoryPerNode, privacy: .public) positions/node")
 
 		let now = Date()
 		let baseNodeNum: Int64 = 0x0A00_0000
@@ -90,6 +99,9 @@ enum PerformanceSeedData {
 		do {
 			try context.save()
 			router.selectedTab = configuration.initialTab
+			if configuration.opensLocalStatsLog {
+				router.selectedNodeNum = baseNodeNum
+			}
 			let duration = Date().timeIntervalSince(start)
 			Logger.data.info("📈 [PerfSeed] Finished seeding \(configuration.nodeCount, privacy: .public) nodes in \(duration, privacy: .public) seconds")
 		} catch {
@@ -199,6 +211,48 @@ enum PerformanceSeedData {
 			environmentMetrics.nodeTelemetry = node
 			context.insert(environmentMetrics)
 		}
+
+		for sample in 0..<configuration.localStatsHistoryPerNode {
+			let timestamp = if configuration.localStatsSameHourSeed {
+				localStatsSameHourTimestamp(now: now, sample: sample)
+			} else {
+				now.addingTimeInterval(TimeInterval(-(sample * 900 + index % 600)))
+			}
+			let localStats = TelemetryEntity()
+			localStats.metricsType = 4
+			localStats.time = timestamp
+			localStats.noiseFloor = syntheticNoiseFloor(nodeIndex: index, sample: sample)
+			localStats.channelUtilization = Float((index * 3 + sample * 5) % 100) / 2
+			localStats.airUtilTx = Float((index + sample * 2) % 80) / 10
+			localStats.numPacketsTx = Int32(120 + index % 70 + sample * 3)
+			localStats.numPacketsRx = Int32(300 + index % 140 + sample * 5)
+			localStats.numPacketsRxBad = Int32((index + sample) % 11)
+			localStats.numRxDupe = Int32((index + sample * 2) % 9)
+			localStats.numTxRelay = Int32((index + sample * 3) % 24)
+			localStats.numTxRelayCanceled = Int32((index + sample) % 4)
+			localStats.numOnlineNodes = Int32(max(1, min(250, configuration.nodeCount - (sample % 12))))
+			localStats.numTotalNodes = Int32(configuration.nodeCount)
+			localStats.uptimeSeconds = Int32(86_400 + index * 60 + sample * 900)
+			localStats.nodeTelemetry = node
+			context.insert(localStats)
+		}
+	}
+
+	private static func localStatsSameHourTimestamp(now: Date, sample: Int) -> Date {
+		let calendar = Calendar.current
+		let currentHourStart = calendar.dateInterval(of: .hour, for: now)?.start ?? now
+		let minute = calendar.component(.minute, from: now)
+		let hourStart = minute < 25 ? currentHourStart.addingTimeInterval(-3_600) : currentHourStart
+		return hourStart.addingTimeInterval(TimeInterval(sample * 300))
+	}
+
+	private static func syntheticNoiseFloor(nodeIndex: Int, sample: Int) -> Int32 {
+		let dailyWave = sin(Double(sample) / 8.0) * 5.0
+		let nodeBias = Double((nodeIndex % 13) - 6)
+		let interferenceSpike = sample.isMultiple(of: 37) ? 14.0 : 0.0
+		let deterministicJitter = (deterministicUnitValue(nodeIndex * 4_096 + sample, salt: 0x8EBC_6AF0_9C88_C6E3) - 0.5) * 6.0
+		let value = -102.0 + dailyWave + nodeBias + interferenceSpike + deterministicJitter
+		return Int32(value.rounded())
 	}
 
 	private static func insertPositions(

Meshtastic/Resources/docs/developer/swiftdata.html

@@ -224,6 +224,11 @@ <h3>Environment variables</h3>
 <td>Device + environment metric samples per node.</td>
 </tr>
 <tr>
+<td><code>MESHTASTIC_PERF_LOCAL_STATS_HISTORY</code></td>
+<td><code>MESHTASTIC_PERF_TELEMETRY_HISTORY</code></td>
+<td>Local stats samples per node, including synthetic noise floor, packet counters, utilization, and node counts.</td>
+</tr>
+<tr>
 <td><code>MESHTASTIC_PERF_POSITION_HISTORY</code></td>
 <td><code>3</code></td>
 <td>Position history entries per node.</td>
@@ -265,9 +270,23 @@ <h3>Example: seed 5 000 nodes with a clean store</h3>
 SIMCTL_CHILD_MESHTASTIC_PERF_COMPACT_LIST=true \
 xcrun simctl launch &lt;UDID&gt; gvh.MeshtasticClient
 </code></pre>
+<h3>Example: seed local stats for noise-floor chart work</h3>
+<p>Use a smaller node count and a larger local stats history when tuning the Local Stats Log UI. This keeps the simulator responsive while giving the chart enough variation to show quiet periods, busy periods, and occasional interference spikes.</p>
+<pre><code class="language-bash">SIMCTL_CHILD_MESHTASTIC_PERF_SEED_NODES=20 \
+SIMCTL_CHILD_MESHTASTIC_PERF_LOCAL_STATS_HISTORY=168 \
+SIMCTL_CHILD_MESHTASTIC_PERF_TELEMETRY_HISTORY=3 \
+SIMCTL_CHILD_MESHTASTIC_PERF_POSITION_HISTORY=3 \
+SIMCTL_CHILD_MESHTASTIC_PERF_RESET_STORE=true \
+SIMCTL_CHILD_MESHTASTIC_PERF_ENABLE_DISCOVERY=0 \
+xcrun simctl launch &lt;UDID&gt; gvh.MeshtasticClient \
+  --meshtastic-perf-seed \
+  --meshtastic-perf-start-local-stats
+</code></pre>
+<p><code>--meshtastic-perf-start-local-stats</code> selects seeded node <code>0x0A000000</code> and opens its Local Stats Log directly in DEBUG simulator builds.</p>
+<p>Add <code>--meshtastic-perf-local-stats-same-hour</code> when checking short-range noise-floor chart layout. It keeps local stats samples in the same hour at 5-minute intervals, which makes <code>1h</code> axis label clipping easy to reproduce.</p>
 <p>On subsequent launches <strong>without</strong> <code>MESHTASTIC_PERF_RESET_STORE</code>, the harness detects the existing node count and skips re-seeding, so the app starts at full speed against the already-seeded store.</p>
 <h3>What to expect</h3>
-<p>5 000 nodes (3 telemetry samples/type, 3 positions/node) seed in approximately <strong>12 seconds</strong> on an Apple Silicon Mac. The app navigates automatically to the Nodes tab. Typical idle CPU after seeding is under 2%.</p>
+<p>5 000 nodes (3 device/environment telemetry samples, 3 local stats samples, 3 positions/node) seed in approximately <strong>12 seconds</strong> on an Apple Silicon Mac. The app navigates automatically to the Nodes tab. Typical idle CPU after seeding is under 2%.</p>
 <blockquote>
 <p><strong>Tip — Checking seed progress</strong>
 Seed log lines are emitted at <code>Info</code> level under the <code>🗄️ Data</code> OSLog category. To stream them:</p>

Meshtastic/Resources/docs/index.json

@@ -944,35 +944,35 @@
             "meshtastic",
             "perf",
             "seed",
+            "node",
+            "simctl",
+            "stats",
             "nodes",
-            "context",
+            "local",
             "store",
-            "node",
+            "context",
+            "packet",
             "model",
+            "history",
+            "child",
             "app",
-            "packet",
             "data",
             "var",
-            "type",
+            "true",
+            "telemetry",
             "swift",
             "save",
-            "messages",
-            "true",
-            "simctl",
-            "set",
-            "schema",
             "position",
             "per",
-            "nodeinfoentity",
+            "messages",
             "launch",
-            "channel",
-            "writes",
             "use",
-            "telemetry",
-            "self",
-            "seeding"
+            "type",
+            "set",
+            "schema",
+            "nodeinfoentity"
         ],
-        "charCount": 8479
+        "charCount": 9767
     },
     {
         "id": "tak-protocol",

Meshtastic/Resources/docs/markdown/developer/swiftdata.md

@@ -189,6 +189,7 @@ Pass variables to the simulator using the `SIMCTL_CHILD_` prefix (the prefix is
 |----------|---------|-------------|
 | `MESHTASTIC_PERF_SEED_NODES` | — | **Required to activate.** Number of nodes to seed (e.g. `5000`). |
 | `MESHTASTIC_PERF_TELEMETRY_HISTORY` | `3` | Device + environment metric samples per node. |
+| `MESHTASTIC_PERF_LOCAL_STATS_HISTORY` | `MESHTASTIC_PERF_TELEMETRY_HISTORY` | Local stats samples per node, including synthetic noise floor, packet counters, utilization, and node counts. |
 | `MESHTASTIC_PERF_POSITION_HISTORY` | `3` | Position history entries per node. |
 | `MESHTASTIC_PERF_DIRECT_MESSAGES` | `0` | Direct messages to seed between node 0 and node 1. |
 | `MESHTASTIC_PERF_CHANNEL_MESSAGES` | `0` | Channel messages to seed on channel 0. |
@@ -213,11 +214,31 @@ SIMCTL_CHILD_MESHTASTIC_PERF_COMPACT_LIST=true \
 xcrun simctl launch <UDID> gvh.MeshtasticClient
 ```
 
+### Example: seed local stats for noise-floor chart work
+
+Use a smaller node count and a larger local stats history when tuning the Local Stats Log UI. This keeps the simulator responsive while giving the chart enough variation to show quiet periods, busy periods, and occasional interference spikes.
+
+```bash
+SIMCTL_CHILD_MESHTASTIC_PERF_SEED_NODES=20 \
+SIMCTL_CHILD_MESHTASTIC_PERF_LOCAL_STATS_HISTORY=168 \
+SIMCTL_CHILD_MESHTASTIC_PERF_TELEMETRY_HISTORY=3 \
+SIMCTL_CHILD_MESHTASTIC_PERF_POSITION_HISTORY=3 \
+SIMCTL_CHILD_MESHTASTIC_PERF_RESET_STORE=true \
+SIMCTL_CHILD_MESHTASTIC_PERF_ENABLE_DISCOVERY=0 \
+xcrun simctl launch <UDID> gvh.MeshtasticClient \
+  --meshtastic-perf-seed \
+  --meshtastic-perf-start-local-stats
+```
+
+`--meshtastic-perf-start-local-stats` selects seeded node `0x0A000000` and opens its Local Stats Log directly in DEBUG simulator builds.
+
+Add `--meshtastic-perf-local-stats-same-hour` when checking short-range noise-floor chart layout. It keeps local stats samples in the same hour at 5-minute intervals, which makes `1h` axis label clipping easy to reproduce.
+
 On subsequent launches **without** `MESHTASTIC_PERF_RESET_STORE`, the harness detects the existing node count and skips re-seeding, so the app starts at full speed against the already-seeded store.
 
 ### What to expect
 
-5 000 nodes (3 telemetry samples/type, 3 positions/node) seed in approximately **12 seconds** on an Apple Silicon Mac. The app navigates automatically to the Nodes tab. Typical idle CPU after seeding is under 2%.
+5 000 nodes (3 device/environment telemetry samples, 3 local stats samples, 3 positions/node) seed in approximately **12 seconds** on an Apple Silicon Mac. The app navigates automatically to the Nodes tab. Typical idle CPU after seeding is under 2%.
 
 > **Tip — Checking seed progress**
 > Seed log lines are emitted at `Info` level under the `🗄️ Data` OSLog category. To stream them:

Meshtastic/Views/Nodes/Helpers/Actions/RequestLocalStatsButton.swift

@@ -5,6 +5,9 @@ struct RequestLocalStatsButton: View {
 	@EnvironmentObject var accessoryManager: AccessoryManager
 
 	var node: NodeInfoEntity
+	var title = "Request Local Stats"
+	var cooldownTitle = "Local Stats"
+	var systemImage = "chart.bar"
 
 	@State
 	private var isPresentingLocalStatsSentAlert: Bool = false
@@ -27,17 +30,19 @@ struct RequestLocalStatsButton: View {
 		} label: { completion in
 			if let completion, completion.percentComplete > 0.0 {
 				Label {
-					Text("Local Stats (in \(Int(completion.secondsRemaining))s)")
+					Text("\(cooldownTitle) \(Int(completion.secondsRemaining))s")
 						.foregroundStyle(.secondary)
+						.lineLimit(1)
 				} icon: {
 					Image("progress.ring.dashed", variableValue: completion.percentComplete)
 						.foregroundStyle(.secondary)
 				}.disabled(true)
 			} else {
 				Label {
-					Text("Request Local Stats")
+					Text(title)
+						.lineLimit(1)
 				} icon: {
-					Image(systemName: "chart.bar")
+					Image(systemName: systemImage)
 						.symbolRenderingMode(.hierarchical)
 				}
 			}