From 7458a9d643633bc0bdae44fa67cd372ad50e6f67 Mon Sep 17 00:00:00 2001 From: bruschill <621389+bruschill@users.noreply.github.com> Date: Sat, 18 Jul 2026 16:27:39 -0500 Subject: [PATCH] fix(canned-messages): stop writing deprecated allow_input_source (#2022) CannedMessageConfig saves derived and wrote the deprecated allowInputSource field (allow_input_source = 10) on every save. The field has been removed from active use upstream with no successor \u2014 the firmware derives the input source from the rotary1Enabled / updown1Enabled flags. - Stop writing cmc.allowInputSource on save. - No read-side change needed: the field was never persisted (absent from the SwiftData model and UpdateSwiftData), so values arriving from older firmware are already ignored without crashing. --- .../Settings/Config/Module/CannedMessagesConfig.swift | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/Meshtastic/Views/Settings/Config/Module/CannedMessagesConfig.swift b/Meshtastic/Views/Settings/Config/Module/CannedMessagesConfig.swift index 9e96a54bb2..13cb9bba80 100644 --- a/Meshtastic/Views/Settings/Config/Module/CannedMessagesConfig.swift +++ b/Meshtastic/Views/Settings/Config/Module/CannedMessagesConfig.swift @@ -188,13 +188,10 @@ struct CannedMessagesConfig: View { cmc.sendBell = sendBell cmc.rotary1Enabled = rotary1Enabled cmc.updown1Enabled = updown1Enabled - if rotary1Enabled { - cmc.allowInputSource = "rotEnc1" - } else if updown1Enabled { - cmc.allowInputSource = "upDown1" - } else { - cmc.allowInputSource = "_any" - } + // allow_input_source is deprecated with no successor — the input + // source is governed by the rotary1Enabled / updown1Enabled flags + // above. Intentionally not written; inbound values from older + // firmware are ignored (never persisted). (#2022) cmc.inputbrokerPinA = UInt32(inputbrokerPinA) cmc.inputbrokerPinB = UInt32(inputbrokerPinB) cmc.inputbrokerPinPress = UInt32(inputbrokerPinPress)