Skip to content

Commit cb00bc8

Browse files
thebenternclaude
andcommitted
fix(v2): build the documents before typechecking in CI
worker/src/generated/ is gitignored -- it is a pure function of the tree, so committing it would be a second source of truth -- which means a fresh checkout does not have it and tsc cannot resolve ./generated/documents.js. Locally the directory already existed from an earlier build, so the ordering mistake was invisible until CI ran on a clean checkout. build:data now runs first. deploy.yml already had the right order. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 1845e2b commit cb00bc8

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,15 @@ jobs:
126126

127127
- run: pnpm install --frozen-lockfile --ignore-scripts=false
128128

129-
- name: Typecheck
130-
run: pnpm typecheck
131-
129+
# build:data FIRST. worker/src/generated/ is gitignored -- it is a pure function of the
130+
# tree, so committing it would be a second source of truth -- which means a fresh checkout
131+
# does not have it and `tsc` cannot resolve ./generated/documents.js until it is built.
132132
- name: Build the published documents
133133
run: pnpm build:data
134134

135+
- name: Typecheck
136+
run: pnpm typecheck
137+
135138
- name: Validate data
136139
run: pnpm validate
137140

0 commit comments

Comments
 (0)