Skip to content

Commit 854eae4

Browse files
authored
QMA6100PSingleton constructor fix pio check warnings (#11313)
Fixes cppcheck issues src/motion/QMA6100PSensor.cpp:173: [medium:warning] Member variable 'QMA6100P::rawAccelData' is not initialized in the constructor. Maybe it should be initialized directly in the class QMA6100P? [uninitDerivedMemberVar] src/motion/QMA6100PSensor.cpp:173: [medium:warning] Member variable 'QMA6100P::_i2cPort' is not initialized in the constructor. Maybe it should be initialized directly in the class QMA6100P? [uninitDerivedMemberVar] src/motion/QMA6100PSensor.cpp:173: [medium:warning] Member variable 'QMA6100P::_deviceAddress' is not initialized in the constructor. Maybe it should be initialized directly in the class QMA6100P? [uninitDerivedMemberVar]
1 parent 88a1866 commit 854eae4

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

src/motion/QMA6100PSensor.cpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,13 @@ QMA6100PSingleton *QMA6100PSingleton::GetInstance()
170170
return pinstance;
171171
}
172172

173-
QMA6100PSingleton::QMA6100PSingleton() {}
173+
// The QMA6100P library leaves these base class members uninitialised until begin() runs
174+
QMA6100PSingleton::QMA6100PSingleton()
175+
{
176+
rawAccelData = {0, 0, 0};
177+
_i2cPort = nullptr;
178+
_deviceAddress = 0;
179+
}
174180

175181
QMA6100PSingleton::~QMA6100PSingleton() {}
176182

0 commit comments

Comments
 (0)