From b298d8944b061e6f90da6b2f87bc15617c5ad643 Mon Sep 17 00:00:00 2001 From: vidplace7 Date: Sat, 1 Aug 2026 09:49:12 -0400 Subject: [PATCH] Remove errant variablereassignment in chatter2 keyboard. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit That line was more than a redundant assignment — it was a latent bug. When shift > 0, the branch sets e.inputEvent = INPUT_BROKER_ANYKEY; e.kbchar = 0x09; (TAB), and the trailing e.kbchar = 0; immediately clobbered the TAB character, so shift+RIGHT emitted an ANYKEY event with a null char. In the non-shift path the assignment was pure noise, since InputEvent e = {} already zeroes it. Removing it makes the RIGHT branch identical in shape to the LEFT branch just above, which never had that line. --- src/input/SerialKeyboard.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/input/SerialKeyboard.cpp b/src/input/SerialKeyboard.cpp index 8037b0d57b8..f69de872c7f 100644 --- a/src/input/SerialKeyboard.cpp +++ b/src/input/SerialKeyboard.cpp @@ -103,7 +103,6 @@ int32_t SerialKeyboard::runOnce() } else { e.inputEvent = INPUT_BROKER_RIGHT; } - e.kbchar = 0; } else if (!(shiftRegister2 & (1 << 1))) { e.inputEvent = INPUT_BROKER_SELECT; } else if (!(shiftRegister2 & (1 << 0))) {