Add OpenMP support on clang / macOS

[kirushyk]

At this moment there is no way to detect OpenMP dependency on clang / macOS using Meson Build.
However OpenMP can be used with clang on macOS with brew install libomp and -Xpreprocess compiler option.

[lesteve]

I added a small reproducer for this in https://github.com/lesteve/meson-openmp-osx.

cc @eli-schwartz that mentioned that this behaviour was unexpected in scikit-learn/scikit-learn#28710 (comment).

We are hitting this in scikit-learn: meson does not find OpenMP but the compilation with OpenMP actually works fine if the right compilation flags are set, see scikit-learn/scikit-learn#28710 for more details.

Looking around I have seen some work-arounds for this behaviour, in a few places for example dipy which has some brew-specific tweaks:
https://github.com/dipy/dipy/blob/95d75a8ad73fe76d7ebaa35b40ee8c734c9b267f/dipy/meson.build#L141-L157

Note that this does not only happen with OpenMP installed with brew but also when downloading OpenMP lib and include folder and setting compilation flags accordingly. This is what we are currently doing in the scikit-learn CI where we download OpenMP lib and include from conda-forge, see scikit-learn/scikit-learn#28710 (comment).

[dcbaker]

Is the -Xpreprocessor needed by GCC as well? or Vanilla (not Apple) Clang? Adding that argument to Meson's OpenMP wrapper should be easy enough. The more complicated question is dealing with the brew specific paths.

[lesteve]

Not an expert, but I believe -Xpreprocessor is Apple Clang specific. Here are some notes about this by Henry Schreiner (a trustable source if you ask me) about this https://iscinumpy.gitlab.io/post/omp-on-high-sierra/.

Just to check, I did a quick test on https://github.com/lesteve/meson-openmp-osx with clang on Linux and Meson finds OpenMP (without setting any environment variable), compiles the test program and running the test program shows that OpenMP is indeed used.

Here is the meson setup output for completeness:

The Meson build system
Version: 1.4.0
Source dir: /home/lesteve/dev/meson-openmp-osx
Build dir: /home/lesteve/dev/meson-openmp-osx/build
Build type: native build
Project name: my-test
Project version: 1.0.0
C compiler for the host machine: clang (clang 17.0.6 "clang version 17.0.6")
C linker for the host machine: clang ld.bfd 2.42.0
Host machine cpu family: x86_64
Host machine cpu: x86_64
Run-time dependency OpenMP for c found: YES 5.1
Build targets in project: 1

Found ninja-1.11.1 at /home/lesteve/micromamba/envs/scikit-learn-dev/bin/ninja

[dcbaker]

Okay, that article is very helpful.

I've opened 13079 as a starting point, which adds the -Xpreprocessor (Unfortunately my Mac is very old and not at hand).

How exactly to handle the rest of it is more complicated. We could inject user supplied arguments into the dependencies, although that seems fragile and is going to be a big project to make sure we're doing that consistently.