Skip to content

Commit b23b686

Browse files
{atinary-lbrey}meta-codesync[bot]
authored andcommitted
Optionally return acq_values (#3209)
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to make BoTorch better. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to BoTorch here: https://github.com/meta-pytorch/botorch/blob/main/CONTRIBUTING.md --> ## Motivation The idea is to optionally returns the acq_values only if needed, else returns None. Also computes them only when necessary to avoid useless forward pass of the acqf. See #3168 for more background. ### Have you read the [Contributing Guidelines on pull requests](https://github.com/meta-pytorch/botorch/blob/main/CONTRIBUTING.md#pull-requests)? Yes I did. Pull Request resolved: #3209 Test Plan: I have updated the API for the `optimize_acqf` and the different flavors of it. I added some test to try out if setting the flag `return_acq_values=False` does indeed return `None` and that by default it returns the `acq_values`. ## Related PRs No related PRs, only this issue #3168 Reviewed By: hvarfner Differential Revision: D96154880 Pulled By: Balandat fbshipit-source-id: 0956e1a419e680b81874c759f98c12b2844466fc
1 parent ddfc4d8 commit b23b686

6 files changed

Lines changed: 598 additions & 50 deletions

File tree

0 commit comments

Comments
 (0)