Bump minimum torch to 2.4#3311
Closed
saitcakmak wants to merge 1 commit into
Closed
Conversation
Torch <2.4 was built against the numpy 1.x C ABI and fails at import time
when paired with numpy 2.x ('numpy not available'). With modern scipy,
jax, and scikit-learn all requiring numpy>=2, capping numpy in the
min-req CI job is no longer feasible. Torch 2.4 (Jul 2024) is the first
release with stable numpy 2.x ABI support, so bump the floor there.
meta-cla
Bot
added
the
CLA Signed
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this in D106575162. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3311 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 226 226
Lines 22470 22470
=======================================
Hits 22466 22466
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@saitcakmak merged this pull request in 720e8be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Torch <2.4 was built against the numpy 1.x C ABI and fails at import time when paired with numpy 2.x ('numpy not available'). With modern scipy, jax, and scikit-learn all requiring numpy>=2, capping numpy in the min-req CI job is no longer feasible. Torch 2.4 (Jul 2024) is the first release with stable numpy 2.x ABI support, so bump the floor there.
Before: https://github.com/meta-pytorch/botorch/actions/runs/26538884146/job/78174986399 fails with Numpy not available.
After: https://github.com/meta-pytorch/botorch/actions/runs/26543456932/job/78190062048 the previously failing tests are passing