Commit 0695faf
Add doc string to Future.get (#4115)
Summary:
Pull Request resolved: #4115
Using `Future.get` in an async event loop can cause issues, and we are recommending users to avoid using it. But it is still confusing to the user on when is a good time to use `Future.get()`. For example I got [this question](pytorch/torchtitan#3449 (comment)).
This diff adds a doc string to this method with a verbose instruction.
Reviewed By: mariusae
Differential Revision: D106826000
fbshipit-source-id: b677d66e1ab0b229123897df2f058daf6f1862171 parent 1e9f722 commit 0695faf
1 file changed
Lines changed: 32 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
110 | 142 | | |
111 | 143 | | |
112 | 144 | | |
| |||
0 commit comments