Ignore return value of function declared with 'warn_unused_result' (#169)

David Eklov · facebook-github-bot · commit 78444abb2d37 · 2022-09-12T12:58:41.000-07:00
Summary: Pull Request resolved: #169 Ignore return value of function declared with 'warn_unused_result' Addresses the following build failure that we get on some of our internal build environments: caffe2/torch/csrc/deploy/environment.h:60:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] system(rmCmd.c_str()); When building locally on a dev server, this compiles just fine, but when building in service lab produced the above build error. Reviewed By: PaliC Differential Revision: D39363916 fbshipit-source-id: 26496c629856284ddddd93d21bc6b0548223207a
diff --git a/multipy/runtime/environment.h b/multipy/runtime/environment.h
@@ -66,7 +66,7 @@ class Environment {
   }
   virtual ~Environment() {
     auto rmCmd = "rm -rf " + extraPythonLibrariesDir_;
-    system(rmCmd.c_str());
+    (void)system(rmCmd.c_str());
   }
   virtual void configureInterpreter(Interpreter* interp) = 0;
   virtual const std::vector<std::string>& getExtraPythonPaths() {

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ class Environment {`
`66`	`66`	`}`
`67`	`67`	`virtual ~Environment() {`
`68`	`68`	`auto rmCmd = "rm -rf " + extraPythonLibrariesDir_;`
`69`		`- system(rmCmd.c_str());`
	`69`	`+ (void)system(rmCmd.c_str());`
`70`	`70`	`}`
`71`	`71`	`virtual void configureInterpreter(Interpreter* interp) = 0;`
`72`	`72`	`virtual const std::vector<std::string>& getExtraPythonPaths() {`