Skip to content

Commit d1a1197

Browse files
authored
Remove some TODOs (#1405)
1 parent 9dd5cc6 commit d1a1197

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

src/torchcodec/_core/Encoder.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,6 @@ torch::stable::Tensor validateFrames(
573573
framesDevice.index());
574574
}
575575
if (avCodecContext) {
576-
// TODO MultiStreamEncoder: Enable tensors in NHWC shape
577576
STD_TORCH_CHECK(
578577
static_cast<int>(frames.sizes()[2]) == avCodecContext->height &&
579578
static_cast<int>(frames.sizes()[3]) == avCodecContext->width,
@@ -832,13 +831,11 @@ void VideoEncoder::initializeEncoder(
832831
avCodecContext_.reset(avCodecContext);
833832

834833
// Store dimensions of input frames
835-
// TODO-VideoEncoder: (P2) Enable tensors in NHWC shape
836834
auto sizes = frames_.sizes();
837835
int inHeight = static_cast<int>(sizes[2]);
838836
int inWidth = static_cast<int>(sizes[3]);
839837

840838
// Always use input dimensions as output dimensions
841-
// TODO-VideoEncoder: (P2) Allow height and width to be set
842839
int outWidth = inWidth;
843840
int outHeight = inHeight;
844841
AVPixelFormat outPixelFormat = AV_PIX_FMT_NONE;
@@ -1217,7 +1214,6 @@ void MultiStreamEncoder::initializeVideoStream(VideoStream& videoStream) {
12171214
avCodecContext != nullptr, "Couldn't allocate codec context.");
12181215
videoStream.avCodecContext.reset(avCodecContext);
12191216

1220-
// TODO MultiStreamEncoder: Allow output height and width to be set
12211217
int outHeight = videoStream.inHeight;
12221218
int outWidth = videoStream.inWidth;
12231219
AVPixelFormat outPixelFormat = AV_PIX_FMT_NONE;
@@ -1254,7 +1250,6 @@ void MultiStreamEncoder::initializeVideoStream(VideoStream& videoStream) {
12541250
videoStream.avCodecContext->width = outWidth;
12551251
videoStream.avCodecContext->height = outHeight;
12561252
videoStream.avCodecContext->pix_fmt = outPixelFormat;
1257-
// TODO MultiStreamEncoder: Add and utilize output frame_rate option
12581253
videoStream.avCodecContext->framerate =
12591254
av_d2q(videoStream.inFrameRate, INT_MAX);
12601255
videoStream.avCodecContext->time_base =
@@ -1426,7 +1421,6 @@ void MultiStreamEncoder::openStreamsAndWriteHeader() {
14261421
void MultiStreamEncoder::addFrames(
14271422
const torch::stable::Tensor& frames,
14281423
int streamIndex) {
1429-
// TODO MultiStreamEncoder: Specify which video stream to add frames to
14301424
STD_TORCH_CHECK(!closed_, "Cannot add frames after close() was called.");
14311425
STD_TORCH_CHECK(headerWritten_, "Call open() before addFrames().");
14321426
STD_TORCH_CHECK(

0 commit comments

Comments
 (0)