-
Notifications
You must be signed in to change notification settings - Fork 71
Open
Labels
best practicesThings we should be doing but aren'tThings we should be doing but aren'tbetter engineeringTasks which help improve eng productivity e.g. building tools, cleaning up code, writing docsTasks which help improve eng productivity e.g. building tools, cleaning up code, writing docs
Description
Context
There are code duplications in our implementations of the trainer.
For example, there is torchforge/src/forge/actors/trainer/titan.py and there is a standalone sft trainer implementation in apps/sft/main.py.
To do
- refactor our trainer implementation in
torchforge/src/forge/actors/trainer/titan.pyto support, for example, SFT - use the new
TitanTrainerin the SFT app
Metadata
Metadata
Assignees
Labels
best practicesThings we should be doing but aren'tThings we should be doing but aren'tbetter engineeringTasks which help improve eng productivity e.g. building tools, cleaning up code, writing docsTasks which help improve eng productivity e.g. building tools, cleaning up code, writing docs