Add support for Gitlab urls in fetch_manifest()

Author: zas

registry_lib/manifest.py

@@ -4,6 +4,7 @@
 
 import requests
 
+
 if sys.version_info >= (3, 11):
     import tomllib
 else:
@@ -16,23 +17,25 @@ def fetch_manifest(git_url, ref="main"):
     """Fetch MANIFEST.toml from git repository.
 
     Args:
-        git_url: Git repository URL (GitHub only)
+        git_url: Git repository URL (GitHub or GitLab)
         ref: Git ref (branch, tag, or commit)
 
     Returns:
         dict: Parsed MANIFEST.toml content
 
     Raises:
-        ValueError: If URL is not GitHub or manifest is invalid
+        ValueError: If URL is not GitHub/GitLab or manifest is invalid
         requests.HTTPError: If manifest cannot be fetched
     """
-    if "github.com" not in git_url:
-        raise ValueError(f"Only GitHub URLs are supported: {git_url}")
-
-    # Convert to raw URL
-    raw_url = git_url.replace("github.com", "raw.githubusercontent.com")
-    raw_url = raw_url.rstrip("/").removesuffix(".git")
-    manifest_url = f"{raw_url}/{ref}/MANIFEST.toml"
+    git_url = git_url.rstrip("/").removesuffix(".git")
+
+    if "github.com" in git_url:
+        raw_url = git_url.replace("github.com", "raw.githubusercontent.com")
+        manifest_url = f"{raw_url}/{ref}/MANIFEST.toml"
+    elif "gitlab.com" in git_url:
+        manifest_url = f"{git_url}/-/raw/{ref}/MANIFEST.toml"
+    else:
+        raise ValueError(f"Only GitHub and GitLab URLs are supported: {git_url}")
 
     response = requests.get(manifest_url, timeout=10)
     response.raise_for_status()

tests/test_manifest.py

@@ -48,10 +48,30 @@ def test_fetch_manifest_with_git_suffix(mock_get):
     assert "plugin/main" in call_url
 
 
-def test_fetch_manifest_non_github():
-    """Test fetch manifest with non-GitHub URL."""
-    with pytest.raises(ValueError, match="Only GitHub URLs are supported"):
-        fetch_manifest("https://gitlab.com/user/plugin")
+@patch("registry_lib.manifest.requests.get")
+def test_fetch_manifest_gitlab(mock_get):
+    """Test successful manifest fetch from GitLab."""
+    mock_response = Mock()
+    mock_response.text = """
+uuid = "12345678-1234-4234-8234-123456789abc"
+name = "Test Plugin"
+version = "1.0.0"
+description = "A test plugin"
+api = ["3.0"]
+"""
+    mock_get.return_value = mock_response
+
+    manifest = fetch_manifest("https://gitlab.com/user/plugin", "main")
+
+    assert manifest["uuid"] == "12345678-1234-4234-8234-123456789abc"
+    call_url = mock_get.call_args[0][0]
+    assert "gitlab.com/user/plugin/-/raw/main/MANIFEST.toml" in call_url
+
+
+def test_fetch_manifest_unsupported():
+    """Test fetch manifest with unsupported URL."""
+    with pytest.raises(ValueError, match="Only GitHub and GitLab URLs are supported"):
+        fetch_manifest("https://bitbucket.org/user/plugin")
 
 
 def test_validate_manifest_valid():