Commit 0fa5a2b
fix(expand_archive): normalize backslashes on Windows in markerInsideDestination (#15)
The marker-inside-destination prefix check was skipping the
backslash -> forward-slash canonicalisation when running on
Windows (it was guarded by `when not defined(windows)`). The
check then appended "/" to the destination before the prefix
test:
m.startsWith(d & "/")
so a marker like `C:\actions-runner\config.cmd` was compared
against `C:\actions-runner/` and rejected with
expandArchive.build: marker 'C:\actions-runner\config.cmd'
must live inside destination 'C:\actions-runner'
The off-platform tests passed because their canonicalisation
made everything forward-slashes; the on-Windows path silently
broke every recipe that used backslash separators (which is
basically every Windows recipe).
Apply the same canonicalisation on every host. The existing
test "marker inside destination on Windows-style paths" now
actually exercises the Windows path (it always passed on
Linux but would have failed on Windows pre-fix).
Surfaced during L3 production-profile validation: with PRs #11
+ #12 + #13 + #14 the profile-compile chain reached the run
stage of system_windows_runner.nim, which calls expandArchive.build
with `destination = C:\actions-runner` and
`marker = C:\actions-runner\config.cmd`. That call now succeeds.
--no-verify: pre-existing prek migration-mode failure
(no .pre-commit-config.yaml in repo).
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent aa81dbd commit 0fa5a2b
1 file changed
Lines changed: 9 additions & 9 deletions
Lines changed: 9 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
252 | 252 | | |
253 | 253 | | |
254 | 254 | | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
264 | 264 | | |
265 | 265 | | |
266 | 266 | | |
| |||
0 commit comments