Commit fc53a5a
committed
repro_cli_support: translate buildNimUnittest.build through nim profile
The `defineCliInterface buildNimUnittest, NimUnittestToolId` typed
tool has no backing binary — its action is conceptually a `nim c`
invocation that compiles a Nim unittest test binary. Without a tool
profile, `lowerGraphAction` raised:
tool-resolution failed: action ct_test_nim_unittest.buildnimunittest-build-XXXX
references executable ct_test_nim_unittest.buildNimUnittest but no
tool profile was resolved for it
so every reprobuild test edge dispatched through `buildNimUnittest`
failed to lower into an executable command, blocking
`./build/bin/repro build test` for the entire 454-edge suite.
Add a focused passthrough in `lowerGraphAction`: when the call's
executable name is `ct_test_nim_unittest.buildNimUnittest` and its
subcommand is `build`, translate the action into a direct `nim c`
invocation using the resolved `nim` profile. The argument mapping is
straightforward:
subcommand "build" -> subcommand "c"
--source=<path> (positional) -> positional <path>
--binary=<path> -> --out:<path>
--threads:on / --hints:off / --warnings:off -> same (verbatim)
--define:<X> / --import:<X> -> same (verbatim)
Pragmatic shim until a typed-tool passthrough feature (a typed tool
that dispatches through an underlying tool's profile, without each
call site re-declaring the binary) lands in the engine. The 454-edge
reprobuild test suite is the primary consumer; the shim unblocks
`repro build test` end-to-end while leaving the broader typed-tool
adapter contract unchanged.1 parent e961956 commit fc53a5a
1 file changed
Lines changed: 99 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1291 | 1291 | | |
1292 | 1292 | | |
1293 | 1293 | | |
| 1294 | + | |
| 1295 | + | |
| 1296 | + | |
| 1297 | + | |
| 1298 | + | |
| 1299 | + | |
| 1300 | + | |
| 1301 | + | |
| 1302 | + | |
| 1303 | + | |
| 1304 | + | |
| 1305 | + | |
| 1306 | + | |
| 1307 | + | |
| 1308 | + | |
| 1309 | + | |
| 1310 | + | |
| 1311 | + | |
| 1312 | + | |
| 1313 | + | |
| 1314 | + | |
| 1315 | + | |
| 1316 | + | |
| 1317 | + | |
| 1318 | + | |
| 1319 | + | |
| 1320 | + | |
| 1321 | + | |
| 1322 | + | |
| 1323 | + | |
| 1324 | + | |
| 1325 | + | |
| 1326 | + | |
| 1327 | + | |
| 1328 | + | |
| 1329 | + | |
| 1330 | + | |
| 1331 | + | |
| 1332 | + | |
| 1333 | + | |
| 1334 | + | |
| 1335 | + | |
| 1336 | + | |
| 1337 | + | |
| 1338 | + | |
| 1339 | + | |
| 1340 | + | |
| 1341 | + | |
| 1342 | + | |
| 1343 | + | |
| 1344 | + | |
| 1345 | + | |
| 1346 | + | |
| 1347 | + | |
| 1348 | + | |
| 1349 | + | |
| 1350 | + | |
| 1351 | + | |
| 1352 | + | |
| 1353 | + | |
| 1354 | + | |
| 1355 | + | |
| 1356 | + | |
| 1357 | + | |
| 1358 | + | |
| 1359 | + | |
| 1360 | + | |
| 1361 | + | |
| 1362 | + | |
| 1363 | + | |
| 1364 | + | |
| 1365 | + | |
| 1366 | + | |
| 1367 | + | |
| 1368 | + | |
| 1369 | + | |
| 1370 | + | |
| 1371 | + | |
| 1372 | + | |
| 1373 | + | |
| 1374 | + | |
| 1375 | + | |
| 1376 | + | |
| 1377 | + | |
| 1378 | + | |
| 1379 | + | |
| 1380 | + | |
| 1381 | + | |
| 1382 | + | |
| 1383 | + | |
| 1384 | + | |
| 1385 | + | |
| 1386 | + | |
| 1387 | + | |
| 1388 | + | |
| 1389 | + | |
| 1390 | + | |
| 1391 | + | |
| 1392 | + | |
1294 | 1393 | | |
1295 | 1394 | | |
1296 | 1395 | | |
| |||
0 commit comments