Skip to content

Commit 61c553a

Browse files
committed
Remove instance argument from dragItemPositioned and fitComplete events
build v1.4.1
1 parent 0928d53 commit 61c553a

File tree

7 files changed

+16
-13
lines changed

7 files changed

+16
-13
lines changed

bower.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "packery",
3-
"version": "1.4.0",
3+
"version": "1.4.1",
44
"author": "Metafizzy",
55
"description": "bin-packing layout library",
66
"main": "js/packery.js",

changelog.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
### v1.4.1
4+
5+
+ Remove `instance` argument from `dragItemPositioned` and `fitComplete` events
6+
37
## v1.4.0
48

59
+ Upgraded Outlayer to `v1.4.0`

dist/packery.pkgd.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*!
2-
* Packery PACKAGED v1.4.0
2+
* Packery PACKAGED v1.4.1
33
* bin-packing layout library
44
*
55
* Licensed GPLv3 for open source use
@@ -3532,7 +3532,7 @@ return Item;
35323532
}));
35333533

35343534
/*!
3535-
* Packery v1.4.0
3535+
* Packery v1.4.1
35363536
* bin-packing layout library
35373537
*
35383538
* Licensed GPLv3 for open source use
@@ -3851,7 +3851,7 @@ Packery.prototype._bindFitEvents = function( item ) {
38513851
if ( ticks != 2 ) {
38523852
return;
38533853
}
3854-
_this.emitEvent( 'fitComplete', [ _this, item ] );
3854+
_this.emitEvent( 'fitComplete', [ item ] );
38553855
}
38563856
// when item is laid out
38573857
item.on( 'layout', function() {
@@ -3996,7 +3996,7 @@ Packery.prototype._getDragEndLayoutComplete = function( elem, item ) {
39963996

39973997
// emit item drag event now that everything is done
39983998
if ( itemNeedsPositioning ) {
3999-
_this.emitEvent( 'dragItemPositioned', [ _this, item ] );
3999+
_this.emitEvent( 'dragItemPositioned', [ item ] );
40004000
}
40014001
// listen once
40024002
return true;

dist/packery.pkgd.min.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/packery.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*!
2-
* Packery v1.4.0
2+
* Packery v1.4.1
33
* bin-packing layout library
44
*
55
* Licensed GPLv3 for open source use
@@ -318,7 +318,7 @@ Packery.prototype._bindFitEvents = function( item ) {
318318
if ( ticks != 2 ) {
319319
return;
320320
}
321-
_this.emitEvent( 'fitComplete', [ _this, item ] );
321+
_this.emitEvent( 'fitComplete', [ item ] );
322322
}
323323
// when item is laid out
324324
item.on( 'layout', function() {
@@ -463,7 +463,7 @@ Packery.prototype._getDragEndLayoutComplete = function( elem, item ) {
463463

464464
// emit item drag event now that everything is done
465465
if ( itemNeedsPositioning ) {
466-
_this.emitEvent( 'dragItemPositioned', [ _this, item ] );
466+
_this.emitEvent( 'dragItemPositioned', [ item ] );
467467
}
468468
// listen once
469469
return true;

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "packery",
3-
"version": "1.4.0",
3+
"version": "1.4.1",
44
"description": "bin-packing layout library",
55
"main": "js/packery.js",
66
"dependencies": {

test/unit/fit.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,8 @@ test( '.fit()', function() {
3434
after( then1, fit2 );
3535
}
3636

37-
pckry.on( 'fitComplete', function( pckryInstance, item ) {
37+
pckry.on( 'fitComplete', function( item ) {
3838
ok( true, 'fitComplete event emitted' );
39-
equal( pckryInstance, pckry, 'packery instance returned' );
4039
equal( item, item3, 'item argument returned' );
4140
equal( elem3.style.left, '30px', 'elem3.style.left = 30px' );
4241
isFit = true;

0 commit comments

Comments
 (0)