Skip to content

Commit 04c3e93

Browse files
fix: fixed stupid mistake in similar papers endpoint
1 parent 796b327 commit 04c3e93

File tree

3 files changed

+10
-22
lines changed

3 files changed

+10
-22
lines changed

backend/src/db/mod.rs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -221,20 +221,14 @@ impl Database {
221221
&self,
222222
course_code: &str,
223223
year: Option<i32>,
224-
course_name: Option<&String>,
225224
semester: Option<&String>,
226225
exam: Option<&String>,
227226
) -> Result<Vec<AdminDashboardQP>, sqlx::Error> {
228-
let query_sql = queries::get_similar_papers_query(
229-
year.is_some(),
230-
course_name.is_some(),
231-
semester.is_some(),
232-
exam.is_some(),
233-
);
227+
let query_sql =
228+
queries::get_similar_papers_query(year.is_some(), semester.is_some(), exam.is_some());
234229
let query = sqlx::query_as(&query_sql).bind(course_code);
235230

236231
let query = query.bind(year);
237-
let query = query.bind(course_name);
238232
let query = query.bind(semester);
239233
let query = query.bind(exam);
240234

backend/src/db/queries.rs

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,29 +5,24 @@
55
use crate::qp::Exam;
66

77
/// Query to get similar papers. Matches `course_code` ($1) always. Other parameters are optional and can be enabled or disabled using the arguments to this function.
8-
pub fn get_similar_papers_query(
9-
year: bool,
10-
course_name: bool,
11-
semester: bool,
12-
exam: bool,
13-
) -> String {
8+
///
9+
/// Query parameters:
10+
/// `$1` - `course_code``
11+
/// `$2` - `year`
12+
/// `$3` - `semester`
13+
/// `$3` - `exam`
14+
pub fn get_similar_papers_query(year: bool, semester: bool, exam: bool) -> String {
1415
let mut param_num = 1;
1516

1617
format!(
17-
"SELECT {} from iqps where is_deleted=false and course_code = $1 {} {} {} {}",
18+
"SELECT {} from iqps where is_deleted=false and course_code = $1 {} {} {}",
1819
ADMIN_DASHBOARD_QP_FIELDS,
1920
if year {
2021
param_num += 1;
2122
format!("AND year=${}", param_num)
2223
} else {
2324
"".to_string()
2425
},
25-
if course_name {
26-
param_num += 1;
27-
format!("AND course_name=${}", param_num)
28-
} else {
29-
"".to_string()
30-
},
3126
if semester {
3227
param_num += 1;
3328
format!("AND semester=${}", param_num)

backend/src/routing/handlers.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,6 @@ pub async fn similar(
428428
body.get("year")
429429
.map(|year| year.parse::<i32>())
430430
.transpose()?,
431-
body.get("course_name"),
432431
body.get("semester"),
433432
body.get("exam"),
434433
)

0 commit comments

Comments
 (0)