Skip to content

Commit 179b7c1

Browse files
Merge pull request #130 from dipamsen/delete-any
Delete any paper
2 parents 09947a5 + 63317d2 commit 179b7c1

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

backend/src/db/mod.rs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ impl Database {
223223
pub async fn soft_delete(&self, id: i32) -> Result<bool, color_eyre::eyre::Error> {
224224
let mut tx = self.connection.begin().await?;
225225

226-
let rows_affected = sqlx::query(queries::SOFT_DELETE_BY_ID)
226+
let rows_affected = sqlx::query(queries::SOFT_DELETE_ANY_BY_ID)
227227
.bind(id)
228228
.execute(&mut *tx)
229229
.await?
@@ -255,7 +255,10 @@ impl Database {
255255
}
256256

257257
/// Permanently deletes a paper from the database
258-
pub async fn hard_delete(&self, id: i32) -> Result<Transaction<'_, Postgres>, color_eyre::eyre::Error> {
258+
pub async fn hard_delete(
259+
&self,
260+
id: i32,
261+
) -> Result<Transaction<'_, Postgres>, color_eyre::eyre::Error> {
259262
let mut tx = self.connection.begin().await?;
260263
let rows_affected = sqlx::query(queries::HARD_DELETE_BY_ID)
261264
.bind(id)
@@ -267,10 +270,10 @@ impl Database {
267270
return Err(eyre!(
268271
"Error: {} (> 1) papers were deleted. Rolling back.",
269272
rows_affected
270-
))
273+
));
271274
} else if rows_affected < 1 {
272275
tx.rollback().await?;
273-
return Err(eyre!("Error: No papers were deleted."))
276+
return Err(eyre!("Error: No papers were deleted."));
274277
}
275278
Ok(tx)
276279
}

backend/src/routing/handlers.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ pub struct DeleteReq {
452452
id: i32,
453453
}
454454

455-
/// Deletes a given paper. Library papers cannot be deleted.
455+
/// (Soft) Deletes a given paper.
456456
///
457457
/// Request format - [`DeleteReq`]
458458
pub async fn delete(
@@ -468,7 +468,7 @@ pub async fn delete(
468468
))
469469
} else {
470470
Ok(BackendResponse::error(
471-
"No paper was changed. Either the paper does not exist, is a library paper (cannot be deleted), or is already deleted.".into(),
471+
"No paper was changed. Either the paper does not exist, or is already deleted.".into(),
472472
StatusCode::BAD_REQUEST,
473473
))
474474
}
@@ -485,7 +485,7 @@ pub struct HardDeleteReq {
485485
pub struct DeleteStatus {
486486
id: i32,
487487
status: Status,
488-
message: String
488+
message: String,
489489
}
490490

491491
/// Hard deletes papers from a list of ids.

0 commit comments

Comments
 (0)