Check if password change is necessary

Author: simcod

cmd/supwd.go

@@ -23,12 +23,18 @@ func (h *hammer) createBmcSuperuser() error {
 
 	bmcConn := h.hal.BMCConnection()
 
-	err = bmcConn.CreateUser(bmcConn.SuperUser(), api.AdministratorPrivilege, resp.SuperUserPassword)
+	changeIsNeeded, err := bmcConn.NeedsPasswordChange(bmcConn.SuperUser(), len(resp.SuperUserPassword), resp.SuperUserPassword)
 	if err != nil {
-		// FIXME: this happens always after the first creation on X12 and newer boards
-		// return fmt.Errorf("failed to create bmc superuser: %s %w", bmcConn.SuperUser().Name, err)
-		h.log.Error("failed to create bmc superuser", "user", bmcConn.SuperUser().Name, "error", err)
-		return nil
+		if changeIsNeeded {
+			err = bmcConn.CreateUser(bmcConn.SuperUser(), api.AdministratorPrivilege, resp.SuperUserPassword)
+			if err != nil {
+				// FIXME: this happens always after the first creation on X12 and newer boards
+				// return fmt.Errorf("failed to create bmc superuser: %s %w", bmcConn.SuperUser().Name, err)
+				h.log.Error("failed to create bmc superuser", "user", bmcConn.SuperUser().Name, "error", err)
+				return nil
+			}
+		}
+		h.log.Error("failed to verify password change for bmc superuser", "user", bmcConn.SuperUser().Name, "error", err)
 	}
 
 	h.log.Info("created superuser", "user", bmcConn.SuperUser().Name)