-
Notifications
You must be signed in to change notification settings - Fork 140
Description
The BMO e2e test suite is relatively light-weight and more comprehensive, in regards to Ironic features tested, than the CAPM3 integration tests. For example, we have recently seen that a change in the ironic-image caused the BMO live-ISO test to fail, while the CAPM3 tests didn't catch the issue. Therefore, we should implement a way to test the ironic-image using the BMO e2e suite.
I think it would be reasonable to test against the latest BMO release (not main), so we only have to build the ironic-image. The most straight forward way to do this is probably to just clone BMO, provide an e2e config file and kustomization specific for ironic-image, and then run the tests using the usual ci-e2e.sh script. For this we would need to make the script a bit more flexible so that we don't have to build the BMO image.
We do have more options though. For example, we could make a re-usable workflow to make it easier to run BMO e2e. This is not much different from the above but it may be nicer to use, especially if we want to use BMO e2e in more places later.
A third option would be to separate the tests from the specs (see metal3-io/baremetal-operator#1626). Then we could implement our own version of them here, just like CAPM3 can re-use the clusterctl-upgrade tests from CAPI. For ironic-image specifically I don't think this makes much sense though.
I would suggest the first or second option to start with.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status