ironic.conf.j2: Allow configuring ipa-collect-lldp via environment variable

[PDCuong]

Description

Current Behavior

Currently, the ipa-collect-lldp parameter in ironic-config/ironic.conf.j2 is hardcoded to 1. This prevents users from disabling LLDP collection during the inspection process when using certain deployment methods like Virtual Media.

In contrast, ironic-config/inspector.ipxe.j2 already correctly implements this as an optional environment variable.

Code Comparison

1. In ironic-config/inspector.ipxe.j2 (Correct):

ipa-collect-lldp={{ env.IRONIC_IPA_COLLECT_LLDP | default('1') }}

2. In ironic-config/ironic.conf.j2 (Hardcoded):

ipa-inspection-dhcp-all-interfaces=1 ipa-collect-lldp=1

Expected Behavior

The ironic.conf.j2 template should use the IRONIC_IPA_COLLECT_LLDP environment variable (consistent with the iPXE template) to allow users to toggle LLDP collection.

---

Proposed Change

In ironic-config/ironic.conf.j2, change the line:

# From:
ipa-inspection-dhcp-all-interfaces=1 ipa-collect-lldp=1

# To:
ipa-inspection-dhcp-all-interfaces=1 ipa-collect-lldp={{ env.IRONIC_IPA_COLLECT_LLDP | default('1') }}

---

Impact

This change allows users to set IRONIC_IPA_COLLECT_LLDP=0 in their environment to skip LLDP collection, which is useful in environments where LLDP is not required or causes delays/issues during bootstrap.

[metal3-io-bot]

This issue is currently awaiting triage.
If Metal3.io contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.