Incorrect liveness probe configuration for Ironic POD

[matthewei]

if we set disableDownloader: true and we can get the flowing result. through the pod can work well. but the livenessProbe isn't right.

  - command:
    - /bin/runhttpd
    env:
    - name: IRONIC_LISTEN_PORT
      value: "6385"
    - name: HTTP_PORT
      value: "6180"
    - name: LISTEN_ALL_INTERFACES
      value: "true"
    - name: USE_IRONIC_INSPECTOR
      value: "false"
    - name: PROVISIONING_INTERFACE
      value: bond0
    image: registry.paas/cmetal/ironic:v0.1.1
    imagePullPolicy: IfNotPresent
    livenessProbe:
      exec:
        command:
        - curl
        - --head
        - --insecure
        - --location
        - --silent
        - --show-error
        - --output
        - /dev/null
        - http://127.0.0.1:6180/images/ironic-python-agent.kernel
      failureThreshold: 12
      initialDelaySeconds: 1
      periodSeconds: 10
      successThreshold: 1
      timeoutSeconds: 5
    name: httpd

[metal3-io-bot]

This issue is currently awaiting triage.
If Metal3.io contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[matthewei]

/cc @dtantsur

[elfosardo]

@matthewei please be more precise here. what's not right in the livenessProbe ?

[dtantsur]

@matthewei I see how this can be confusing, and maybe we need to drop the path from the URL. But the trick here is that without --fail argument curl does not return an error code on HTTP 403 or 404, only on network problems.

[Rozzii]

/triage needs-information
I was tempted to put invalid on this but let's see if the discussion goes anywhere.