Skip to content

lib/common.sh has passwordless sudo check #1288

@tuminoid

Description

@tuminoid

The passwordless sudo check in lib/common.sh is really idiotic. It requires you to have passwordless sudo in the first place, and secondly it needs to be configured the exact way that it then checks.

Instead, the script should just check that it is running as root, and should not run anything with sudo. Then it is up to user to run the top-level command with sudo, which allows it to have password or configure the passwordless in any way user wants.

In general, any lib should not execute code, but only define functions for scripts to execute.

Metadata

Metadata

Assignees

No one assigned

    Labels

    lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.triage/acceptedIndicates an issue is ready to be actively worked on.

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions