-
Notifications
You must be signed in to change notification settings - Fork 128
Open
Labels
lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.triage/acceptedIndicates an issue is ready to be actively worked on.Indicates an issue is ready to be actively worked on.
Description
The passwordless sudo check in lib/common.sh is really idiotic. It requires you to have passwordless sudo in the first place, and secondly it needs to be configured the exact way that it then checks.
Instead, the script should just check that it is running as root, and should not run anything with sudo. Then it is up to user to run the top-level command with sudo, which allows it to have password or configure the passwordless in any way user wants.
In general, any lib should not execute code, but only define functions for scripts to execute.
lentzi90
Metadata
Metadata
Assignees
Labels
lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.triage/acceptedIndicates an issue is ready to be actively worked on.Indicates an issue is ready to be actively worked on.
Type
Projects
Status
Backlog