Is the ProgramAllowList working as intended?

[obumnwabude]

I created a collection with the Royalties Plugin and added the AllowProgramList in the ruleSet. However, the call fails on-chain with reject against line 128, just below the lines I linked. On continuous debugging, I cycled here and found out that the if condition expects the new_owner to be in the AllowProgramList. But the new owner is not a program. Infact, there will be multiple new owners in different places. Or does new owner mean something else here? Kindly look into this or what was the intended behavior? And is authority_info validly the calling program?

mpl-core/programs/mpl-core/src/plugins/internal/authority_managed/royalties.rs

Lines 123 to 124 in 276f2a2

	if allow_list.contains(ctx.authority_info.owner)
	&& allow_list.contains(new_owner.owner)

[blockiosaurus]

This is intended behavior. The owner in this case is the program that owns the account. For normal wallets, you would want the system program in your allowlist

[obumnwabude]

... The owner in this case is the program that owns the account. ...

I don't understand the above line. What is the "account" in your sentence above? The collection?

Thanks for the info about normal wallets, but no, the allow list member here wasn't a normal wallet but this is a custom NFT Marketplace program that is in the AllowList.

For Context, I'm making these calls in FOGO Testnet.

In this Marketplace program, in its buy instruction, it fetches the royalties plugin on the asset/collection, computes royalties for creators and distributes if any, computes for the "platform" itself, and sends the rest to the seller of the asset. In the same call, it transfers ownership of the asset to the buyer with MPL core program.

When rule_set in the Royalties Plugin is None, the transfer progresses smoothly. Look at the program logs (at the end of the explorer page) in this transaction: https://explorer.fogo.io/tx/2scPsocTZEsmkdZ1yVEqSAa9VMA7bJndpccHXpi7beVBN4Z8kse8EoetVczqyjphZAdtGvCTDgsMxHp2maF5M1Cd?cluster=testnet You see how the royalties were fetched and logged and the other logic flows successed.

But I now came and temporarily updated the royalties plugin to include this same NFT marketplace program in the ProgramAllowList. Then proceeded to make the same buy call. This time, the call failed because of the rule_set. The log of the fetched royalties plugin in the transaction validly contains the Program's ID in the rule_set. You can verify this in the logs. https://explorer.fogo.io/tx/3mG7xHS58WvYwvnxiBAVacdDCTsUr78fDeR6MPMTww8KPXRju3YAay69UeQnFdjLHbwc8L8gL7RoFbj14Eb38f7Q?cluster=testnet

So I was surprised and was investigating and now came here to the source code as pointed by the ".../royalties.rs:128:Reject" line in the logs from the MPL Core CPI call.

So how do I set the rule_set to allow this Marketplace program to make the transfers?

[blockiosaurus]

I am referring to the Account ownership hierarchy model used by the SVM. The system program (11111111111111111111111111111111) owns all accounts by default. This includes most oncurve wallets that users sign with. PDAs used by programs, like in the case of your marketplace, are most likely owned by your program if it stores data. The account owner of the source and destination are what is checked by the Rule Set allowlist. If you want to enable standard wallet destinations like in the case you described above, you need to add the System Program to your allowlist.