GitHub API V3/V4 issues track

[meteorlxy]

Common

• Ask for too much permissions (see Request minimal github access #39): https://developer.github.com/apps/building-oauth-apps/understanding-scopes-for-oauth-apps/#available-scopes
• Potential security issue about clientSecret (see Something about the clientSecret of GitHub #16)

GitHub API V3

• Comments not sortable: sort and direction params are missed in https://developer.github.com/v3/issues/comments/#list-comments-on-an-issue

[syhyz1990]

vuepress 插件 设置为github-v4时 , 模板指定issueId

会返回错误 无法将值“ 270”强制转换为Int

[meteorlxy]

@syhyz1990

// wrong
<Vssue issue-id="270" />

// correct
<Vssue :issue-id="270" />

[DynamicLoader]

I found a way to use github app with API v4 instead of using github oauth app with API v3.Just need to create a new github app,and give it issue R/W permission,and use vssue.github-v4.js instead of vssue-github.js.

[meteorlxy]

@Lucy2003 Sounds cool! I'll take a look

[DynamicLoader]

Github API v4版本的请求头accept是否应改为 'application/vnd.github.v4+json' ?

还是说，由于要用一部分API v3的功能，所以要用 'application/vnd.github.v3+json' ?

[meteorlxy]

还是说，由于要用一部分API v3的功能，所以要用 'application/vnd.github.v3+json' ?

后者

[RehanSaeed]

Any progress on reducing the amount of permissions required?

[realpdai]

@meteorlxy

Vssue 不支持IE 11，可以看所有vssue demo页面在IE下的表现，需要考虑下兼容性问题。

[meteorlxy]

@realpdai 你说的可能是 vuepress 在 ie11 的兼容问题？