ounits actually had to be str|None to match upstream type. Change reverted and type adjusted.

Author: ways

bris/units.py

@@ -76,7 +76,7 @@ def get_conversion_map() -> dict[tuple[str, str], tuple[float, float]]:
     return linear_convert
 
 
-def find_common_name(units: str) -> str:
+def find_common_name(units: str | None) -> str:
     """Finds a more common name for a strange unit, e.g. celsius instead of C or degC
 
     Args:
@@ -108,7 +108,7 @@ def find_common_name(units: str) -> str:
     return units
 
 
-def convert(array, iunits: str, ounits: str = "", inplace: bool = False):
+def convert(array, iunits: str, ounits: str | None = None, inplace: bool = False):
     """Converts data from one unit to another
 
     Args:
@@ -127,7 +127,7 @@ def convert(array, iunits: str, ounits: str = "", inplace: bool = False):
     original_ounits = ounits
     iunits = find_common_name(iunits)
     ounits = find_common_name(ounits)
-    if original_ounits == "":
+    if original_ounits is None:
         original_ounits = ounits
 
     if inplace and not isinstance(array, np.ndarray):