Skip to content

Rose Edit: Format Widget #2941

@wxtim

Description

@wxtim
  1. This widget is not (as far as I can see) well documented, or tested.
  2. My best efforts at testing it, suggest that it's broken.

Replicate

# rose-app.conf
[env]
biscuit="Rich Tea"
# meta/rose-meta.conf
[env=biscuit]
values="Rich Tea","Nice","Malted Milk"
widget[rose-config-edit]=rose.config_editor.valuewidget.format.FormatsChooserValueWidget

> rose edit -C ./meta/
tim.pillinger@cazldf000086:/home/users/tim.pillinger/cylc-src/rose-apps/meta> [FAIL] Could not import widget: free variable 'meta' referenced before assignment in enclosing scope

## Possible fix

```diff
+++ b/metomi/rose/config_editor/valuewidget/format.py
@@ -40,8 +40,10 @@ class FormatsChooserValueWidget(Gtk.Box):
         self.set_value = set_value
         self.hook = hook
 
+        meta = self.metadata
+
         if "values_getter" in self.metadata:
-            meta = self.metadata
             self.values_getter = meta["values_getter"]
         else:
             self.values_getter = lambda: meta.get("values", [])

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions