align :float and :double generators

Author: frenchy64

CHANGELOG.md

@@ -21,6 +21,7 @@ Malli is in well matured [alpha](README.md#alpha).
   * previous behavior defaulted to a `nil`-returning generator, even if the schema doesn't accept `nil`
   * use `:gen/return nil` property to restore this behavior
 * FIX: `malli.registry/{mode,type}` not respected in Babashka [#1124](https://github.com/metosin/malli/issues/1124)
+* FIX: `:float` accepts doubles but never generates them [#1132](https://github.com/metosin/malli/issues/1132)
 * Updated dependencies:
 
 ```

src/malli/generator.cljc

@@ -428,6 +428,14 @@
     (gen/return (first es))
     (gen/elements es)))
 
+(defn- double-gen [schema options]
+  (gen/double* (merge (let [props (m/properties schema options)]
+                        {:infinite? (get props :gen/infinite? false)
+                         :NaN? (get props :gen/NaN? false)})
+                      (-> (-min-max schema options)
+                          (update :min #(some-> % double))
+                          (update :max #(some-> % double))))))
+
 (defmulti -schema-generator (fn [schema options] (m/type schema options)) :default ::default)
 
 (defmethod -schema-generator ::default [schema options] (ga/gen-for-pred (m/validator schema options)))
@@ -476,28 +484,8 @@
 (defmethod -schema-generator :nil [_ _] nil-gen)
 (defmethod -schema-generator :string [schema options] (-string-gen schema options))
 (defmethod -schema-generator :int [schema options] (gen/large-integer* (-min-max schema options)))
-(defmethod -schema-generator :double [schema options]
-  (gen/double* (merge (let [props (m/properties schema options)]
-                        {:infinite? (get props :gen/infinite? false)
-                         :NaN? (get props :gen/NaN? false)})
-                      (-> (-min-max schema options)
-                          (update :min #(some-> % double))
-                          (update :max #(some-> % double))))))
-(defmethod -schema-generator :float [schema options]
-  (let [max-float #?(:clj Float/MAX_VALUE :cljs (.-MAX_VALUE js/Number))
-        min-float (- max-float)
-        props (m/properties schema options)
-        min-max-props (-min-max schema options)
-        infinite? #?(:clj false :cljs (get props :gen/infinite? false))]
-    (->> (merge {:infinite? infinite?
-                 :NaN? (get props :gen/NaN? false)}
-                (-> min-max-props
-                    (update :min #(or (some-> % float)
-                                      #?(:clj min-float :cljs nil)))
-                    (update :max #(or (some-> % float)
-                                      #?(:clj max-float :cljs nil)))))
-         (gen/double*)
-         (gen/fmap float))))
+(defmethod -schema-generator :double [schema options] (double-gen schema options))
+(defmethod -schema-generator :float [schema options] (double-gen schema options))
 (defmethod -schema-generator :boolean [_ _] gen/boolean)
 (defmethod -schema-generator :keyword [_ _] gen/keyword)
 (defmethod -schema-generator :symbol [_ _] gen/symbol)

test/malli/generator_test.cljc

@@ -1137,3 +1137,8 @@
                   [{} :map]]]
       (is (every? #{{:type nil} {:type {}}} (mg/sample schema)))
       (is (every? (m/validator schema) (mg/sample schema))))))
+
+(deftest float-generates-doubles-test
+  (doseq [v (mg/sample :float)]
+    (is (m/validate :float v))
+    (is (double? v))))