Merge pull request #1146 from metosin/fix-ref-map-default-1145

look inside :ref when searching for default for :map child

Author: ikitommi

src/malli/transform.cljc

@@ -486,7 +486,9 @@
                                                                (when (or (not optional) add-optional-keys)
                                                                  (let [e (find p key)]
                                                                    (when-some [f (if e (constantly (val e))
-                                                                                       (get-default v))]
+                                                                                       (or (get-default v)
+                                                                                           (when (m/-ref-schema? v)
+                                                                                             (get-default (m/-deref v)))))]
                                                                      [k (fn [] (default-fn schema (f)))])))))
                                                        (m/children schema))]
                                     (when (seq defaults)

test/malli/transform_test.cljc

@@ -3,6 +3,7 @@
             [clojure.test :refer [are deftest is testing]]
             [malli.core :as m]
             [malli.core-test]
+            [malli.registry :as mr]
             [malli.transform :as mt])
   #?(:clj (:import (java.net URI))))
 
@@ -1032,7 +1033,18 @@
 
   (testing ":default/fn property on schema"
     (let [schema [:string {:default/fn (fn [] "called")}]]
-      (is (= "called" (m/decode schema nil mt/default-value-transformer))))))
+      (is (= "called" (m/decode schema nil mt/default-value-transformer)))))
+
+  (testing ":refs"
+    (let [opts {:registry (mr/composite-registry m/default-registry
+                                                 {"bing" :int})}
+          transformer (mt/default-value-transformer {:defaults {:int (constantly 7)}})]
+      (is (= 7 (m/decode [:ref "bing"] nil opts transformer)))
+      (is (= [7] (m/decode [:vector [:ref "bing"]] [nil] opts transformer)))
+      (is (= {:a 7} (m/decode [:map [:a [:ref "bing"]]] {:a nil} opts transformer)))
+      (is (= {:a 7} (m/decode [:map [:a [:ref "bing"]]] {} opts transformer)))
+      (is (= {:a 8} (m/decode [:map [:a [:ref {:default 8} "bing"]]] {:a nil} opts transformer)))
+      (is (= {:a 8} (m/decode [:map [:a [:ref {:default 8} "bing"]]] {} opts transformer))))))
 
 (deftest type-properties-based-transformations
   (is (= 12 (m/decode malli.core-test/Over6 "12" mt/string-transformer))))