Skip to content

Commit e2993ef

Browse files
millordludtkemorgan
authored andcommitted
feat: Waitlist Lottery - Adjust Doorway Listing Type Filter (bloom-housing#5559)
updated filtering logic for waitlist open
1 parent e78d11b commit e2993ef

2 files changed

Lines changed: 18 additions & 6 deletions

File tree

api/src/services/listing.service.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -763,9 +763,12 @@ export class ListingService implements OnModuleInit {
763763
};
764764
} else if (availability === FilterAvailabilityEnum.waitlistOpen) {
765765
const builtFilter = buildFilter({
766-
$comparison: Compare['='],
766+
$comparison: Compare.IN,
767767
$include_nulls: false,
768-
value: ReviewOrderTypeEnum.waitlist,
768+
value: [
769+
ReviewOrderTypeEnum.waitlist,
770+
ReviewOrderTypeEnum.waitlistLottery,
771+
],
769772
key: ListingFilterKeys.availabilities,
770773
caseSensitive: true,
771774
});
@@ -879,9 +882,12 @@ export class ListingService implements OnModuleInit {
879882
FilterAvailabilityEnum.waitlistOpen
880883
) {
881884
const builtFilter = buildFilter({
882-
$comparison: filter.$comparison,
885+
$comparison: Compare.IN,
883886
$include_nulls: false,
884-
value: ReviewOrderTypeEnum.waitlist,
887+
value: [
888+
ReviewOrderTypeEnum.waitlist,
889+
ReviewOrderTypeEnum.waitlistLottery,
890+
],
885891
key: ListingFilterKeys.availability,
886892
caseSensitive: true,
887893
});

api/test/unit/services/listing.service.spec.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1475,7 +1475,10 @@ describe('Testing listing service', () => {
14751475
OR: [
14761476
{
14771477
reviewOrderType: {
1478-
equals: ReviewOrderTypeEnum.waitlist,
1478+
in: [
1479+
ReviewOrderTypeEnum.waitlist,
1480+
ReviewOrderTypeEnum.waitlistLottery,
1481+
],
14791482
},
14801483
},
14811484
],
@@ -1672,7 +1675,10 @@ describe('Testing listing service', () => {
16721675
OR: [
16731676
{
16741677
reviewOrderType: {
1675-
equals: ReviewOrderTypeEnum.waitlist,
1678+
in: [
1679+
ReviewOrderTypeEnum.waitlist,
1680+
ReviewOrderTypeEnum.waitlistLottery,
1681+
],
16761682
},
16771683
},
16781684
],

0 commit comments

Comments
 (0)