fix: toggle off building selection criteria (bloom-housing#5632)

* fix: add disableBuildingSelectionCriteria flag

* refactor: change seed feature flags order

* fix: add disableBuildingSelectionCriteria to featureFlagMap

* fix: hide csv export when all jurisdiction flags are true

Author: KrissDrawing

api/prisma/seed-staging.ts

@@ -270,6 +270,7 @@ export const stagingSeed = async (
   const angelopolisJurisdiction = await prismaClient.jurisdictions.create({
     data: jurisdictionFactory('Angelopolis', {
       featureFlags: [
+        FeatureFlagEnum.disableBuildingSelectionCriteria,
         FeatureFlagEnum.enableAccessibilityFeatures,
         FeatureFlagEnum.enableCreditScreeningFee,
         FeatureFlagEnum.enableHousingDeveloperOwner,

api/src/enums/feature-flags/feature-flags-enum.ts

@@ -2,6 +2,7 @@
 // Note, these are just used to keep backend and frontend in sync. We store feature flags as strings so this list might not include every flag.
 // Keep alphabetized for readability.
 export enum FeatureFlagEnum {
+  disableBuildingSelectionCriteria = 'disableBuildingSelectionCriteria',
   disableCommonApplication = 'disableCommonApplication',
   disableJurisdictionalAdmin = 'disableJurisdictionalAdmin',
   disableListingPreferences = 'disableListingPreferences',
@@ -55,6 +56,11 @@ export const featureFlagMap: {
   name: string;
   description: string;
 }[] = [
+  {
+    name: FeatureFlagEnum.disableBuildingSelectionCriteria,
+    description:
+      'When true, building selection criteria is not displayed in the listing',
+  },
   {
     name: FeatureFlagEnum.disableCommonApplication,
     description:

api/src/services/listing-csv-export.service.ts

@@ -975,11 +975,18 @@ export class ListingCsvExporterService implements CsvExporterServiceInterface {
           path: 'rentalAssistance',
           label: 'Eligibility Rules - Rental Assistance',
         },
-        {
-          path: 'buildingSelectionCriteria',
-          label: 'Building Selection Criteria',
-          format: this.buildingSelectionCriteria,
-        },
+        ...(doAnyJurisdictionHaveFalsyFeatureFlagValue(
+          user.jurisdictions,
+          FeatureFlagEnum.disableBuildingSelectionCriteria,
+        )
+          ? [
+              {
+                path: 'buildingSelectionCriteria',
+                label: 'Building Selection Criteria',
+                format: this.buildingSelectionCriteria,
+              },
+            ]
+          : []),
         {
           path: 'programRules',
           label: 'Important Program Rules',

shared-helpers/src/types/backend-swagger.ts

@@ -4308,7 +4308,7 @@ export interface UnitsSummary {
   totalAvailable?: number
 
   /**  */
-  rentType?: string
+  rentType?: RentTypeEnum
 
   /**  */
   flatRentValueFrom?: number
@@ -5017,7 +5017,7 @@ export interface UnitsSummaryCreate {
   totalAvailable?: number
 
   /**  */
-  rentType?: string
+  rentType?: RentTypeEnum
 
   /**  */
   flatRentValueFrom?: number
@@ -8284,6 +8284,7 @@ export enum NeighborhoodAmenitiesEnum {
 }
 
 export enum FeatureFlagEnum {
+  "disableBuildingSelectionCriteria" = "disableBuildingSelectionCriteria",
   "disableCommonApplication" = "disableCommonApplication",
   "disableJurisdictionalAdmin" = "disableJurisdictionalAdmin",
   "disableListingPreferences" = "disableListingPreferences",

sites/partners/src/components/listings/PaperListingDetails/sections/DetailAdditionalEligibility.tsx

@@ -1,12 +1,20 @@
 import React, { useContext } from "react"
 import { t, MinimalTable, TableThumbnail } from "@bloom-housing/ui-components"
 import { FieldValue, Grid } from "@bloom-housing/ui-seeds"
+import { AuthContext } from "@bloom-housing/shared-helpers"
+import { FeatureFlagEnum } from "@bloom-housing/shared-helpers/src/types/backend-swagger"
 import { ListingContext } from "../../ListingContext"
 import { getDetailFieldString } from "./helpers"
 import SectionWithGrid from "../../../shared/SectionWithGrid"
 
 const DetailAdditionalEligibility = () => {
   const listing = useContext(ListingContext)
+  const { doJurisdictionsHaveFeatureFlagOn } = useContext(AuthContext)
+
+  const disableBuildingSelectionCriteria = doJurisdictionsHaveFeatureFlagOn(
+    FeatureFlagEnum.disableBuildingSelectionCriteria,
+    listing.jurisdictions.id
+  )
 
   return (
     <SectionWithGrid heading={t("listings.sections.additionalEligibilityTitle")} inset>
@@ -43,50 +51,51 @@ const DetailAdditionalEligibility = () => {
       </Grid.Row>
 
       {(listing.buildingSelectionCriteria ||
-        listing.listingsBuildingSelectionCriteriaFile?.fileId) && (
-        <Grid.Row columns={1}>
-          <Grid.Cell>
-            <FieldValue label={t("listings.buildingSelectionCriteria")}>
-              {listing.listingsBuildingSelectionCriteriaFile?.fileId ? (
-                <MinimalTable
-                  id="buildingSelectionCriteriaTable"
-                  headers={{ preview: "t.preview", fileName: "t.fileName" }}
-                  data={[
-                    {
-                      preview: {
-                        content: (
-                          <TableThumbnail>
-                            <img
-                              alt="PDF preview"
-                              src={listing.listingsBuildingSelectionCriteriaFile.fileId}
-                            />
-                          </TableThumbnail>
-                        ),
+        listing.listingsBuildingSelectionCriteriaFile?.fileId) &&
+        !disableBuildingSelectionCriteria && (
+          <Grid.Row columns={1}>
+            <Grid.Cell>
+              <FieldValue label={t("listings.buildingSelectionCriteria")}>
+                {listing.listingsBuildingSelectionCriteriaFile?.fileId ? (
+                  <MinimalTable
+                    id="buildingSelectionCriteriaTable"
+                    headers={{ preview: "t.preview", fileName: "t.fileName" }}
+                    data={[
+                      {
+                        preview: {
+                          content: (
+                            <TableThumbnail>
+                              <img
+                                alt="PDF preview"
+                                src={listing.listingsBuildingSelectionCriteriaFile.fileId}
+                              />
+                            </TableThumbnail>
+                          ),
+                        },
+                        fileName: {
+                          content: `${listing.listingsBuildingSelectionCriteriaFile.fileId
+                            .split("/")
+                            .slice(-1)
+                            .join()}.pdf`,
+                        },
                       },
-                      fileName: {
-                        content: `${listing.listingsBuildingSelectionCriteriaFile.fileId
-                          .split("/")
-                          .slice(-1)
-                          .join()}.pdf`,
+                    ]}
+                  />
+                ) : (
+                  <MinimalTable
+                    id="buildingSelectionCriteriaTable"
+                    headers={{ url: "t.url" }}
+                    data={[
+                      {
+                        url: { content: listing.buildingSelectionCriteria },
                       },
-                    },
-                  ]}
-                />
-              ) : (
-                <MinimalTable
-                  id="buildingSelectionCriteriaTable"
-                  headers={{ url: "t.url" }}
-                  data={[
-                    {
-                      url: { content: listing.buildingSelectionCriteria },
-                    },
-                  ]}
-                />
-              )}
-            </FieldValue>
-          </Grid.Cell>
-        </Grid.Row>
-      )}
+                    ]}
+                  />
+                )}
+              </FieldValue>
+            </Grid.Cell>
+          </Grid.Row>
+        )}
     </SectionWithGrid>
   )
 }

sites/partners/src/components/listings/PaperListingForm/index.tsx

@@ -596,7 +596,10 @@ const ListingForm = ({
                             listing={listing}
                             requiredFields={requiredFields}
                           />
-                          <BuildingSelectionCriteria />
+                          {!doJurisdictionsHaveFeatureFlagOn(
+                            FeatureFlagEnum.disableBuildingSelectionCriteria,
+                            jurisdictionId
+                          ) && <BuildingSelectionCriteria />}
                           <AdditionalDetails
                             existingDocuments={listing?.requiredDocumentsList}
                             requiredFields={requiredFields}

sites/public/src/components/listing/ListingViewSeedsHelpers.tsx

@@ -399,6 +399,11 @@ export const getEligibilitySections = (
     FeatureFlagEnum.disableListingPreferences
   )
 
+  const disableBuildingSelectionCriteria = isFeatureFlagOn(
+    jurisdiction,
+    FeatureFlagEnum.disableBuildingSelectionCriteria
+  )
+
   // Reserved community type
   if (!swapCommunityTypeWithPrograms && listing.reservedCommunityTypes) {
     eligibilityFeatures.push({
@@ -544,8 +549,8 @@ export const getEligibilitySections = (
     listing.creditHistory ||
     listing.rentalHistory ||
     listing.criminalBackground ||
-    listing.listingsBuildingSelectionCriteriaFile ||
-    listing.buildingSelectionCriteria
+    ((listing.listingsBuildingSelectionCriteriaFile || listing.buildingSelectionCriteria) &&
+      !disableBuildingSelectionCriteria)
   ) {
     const cardContent: ContentCardProps[] = []
     if (listing.creditHistory)
@@ -569,7 +574,7 @@ export const getEligibilitySections = (
       content: (
         <>
           <CardList cardContent={cardContent} />
-          {getBuildingSelectionCriteria(listing)}
+          {!disableBuildingSelectionCriteria && getBuildingSelectionCriteria(listing)}
         </>
       ),
     })