better PID-list management/messaging

Author: mezantrop

CHANGELOG.md

@@ -1,6 +1,8 @@
 # CHANGELOG
 
 * **2025.06.05    Current - ts-warp-1.5.8, gui-warp-1.0.27 (gui-warp-v1.0.34-mac), ns-warp-1.0.7**
+  * `ts-warp.c, pidlist.c`: better `PID`-list management
+  * `inifile.c`: suppress negative name lookup messages
   * `gui-warp.py`: INI-tab Text-field resizing corrected
 
 * **2025.06.04    ts-warp-1.5.8, gui-warp-1.0.27 (gui-warp-v1.0.34-mac), ns-warp-1.0.7**

inifile.c

@@ -429,6 +429,11 @@ struct ini_section *getsection(struct ini_section *ini, char *name) {
 
     struct ini_section *s;
 
+    if (!name || !name[0]) {
+        printl(LOG_VERB, "getsection(): Empty section name queried!");
+        return NULL;
+    }
+
     s = ini;
     while (s) {
         if (!strcmp(s->section_name, name)) {
@@ -595,16 +600,14 @@ struct ini_section *ini_look_server(struct ini_section *ini, struct uvaddr addr_
         while (t) {
             if ((t->target_type == INI_TARGET_HOST || t->target_type == INI_TARGET_DOMAIN)) {
                 /* Perform namelookup only if section has target_host or target_domain */
-                if (!addr_u.name[0] && getnameinfo((struct sockaddr *)&addr_u.ip_addr, sizeof(addr_u.ip_addr), host,
-                        sizeof host, 0, 0, NI_NAMEREQD))
-                            printl(LOG_VERB, "Unspecified / irresolvable hostname: [%s]",
-                                inet2str(&addr_u.ip_addr, buf1));
-                else
-                    if (!domain && (domain = strchr(host, '.'))) {
+                if (!addr_u.name[0] &&
+                    getnameinfo((struct sockaddr *)&addr_u.ip_addr, sizeof(addr_u.ip_addr),
+                        host, sizeof host, 0, 0, NI_NAMEREQD) == 0 &&
+                    !domain && (domain = strchr(host, '.'))) {
                         domainlen = strnlen(++domain, HOST_NAME_MAX - 1);
                         printl(LOG_VERB, "IP: [%s] resolves to: [%s] domain: [%s]",
-                            inet2str(&addr_u.ip_addr, buf1), host, domain?:"");
-                    }
+                            inet2str(&addr_u.ip_addr, buf1), host, domain ? : "");
+                }
             }
 
             switch(t->target_type) {

pidlist.c

@@ -62,7 +62,7 @@ struct pid_list *pidlist_add(struct pid_list *root, char *section_name, pid_t pi
         c->next = n;
     }
 
-    printl(LOG_INFO, "Clients list. Added PID: [%d], Section: [%s]", n->pid, n->section_name);
+    printl(LOG_INFO, "Clients list. Added PID: [%d]", n->pid);
     return root;
 }
 

ts-warp.c

@@ -590,14 +590,6 @@ All parameters are optional:
         fcntl(csock, F_SETFL, ~O_NONBLOCK);                         /* Don't block client connections */
         printl(LOG_INFO, "Client: [%d], IP: [%s] accepted", cn++, inet2str(&caddr, buf));
 
-        /* -- Get the client original destination from NAT ---------------------------------------------------------- */
-
-        /* Initialize  daddr */
-        daddr_len = sizeof(daddr.ip_addr);
-        memset(&daddr.ip_addr, 0, daddr_len);
-        memset(&daddr.name, 0, sizeof(daddr.name) - 1);
-        daddr.ip_addr.ss_family = caddr.ss_family;
-
         /* -- Process the PIDs list: remove exitted clients and execute workload balance functions ------------------ */
         c = pids;
 
@@ -609,7 +601,7 @@ All parameters are optional:
 
         while (c) {
             push_ini = NULL;
-            if (!c->section_name || strlen(c->section_name) == 0) {
+            if (c->traffic.daddr.ss_family && (!c->section_name || strlen(c->section_name) == 0)) {
                 tmp_daddr.ip_addr = c->traffic.daddr;
                 if ((push_ini = ini_look_server(ini_root, tmp_daddr))) {
                     free(c->section_name);
@@ -619,7 +611,8 @@ All parameters are optional:
 
             if (c == pids && c->status >= 0) {                              /* Remove pidlist root entry */
                 pids = c->next;
-                if (!push_ini) push_ini = getsection(ini_root, c->section_name);
+                if (!push_ini && c->section_name && c->section_name[0])
+                    push_ini = getsection(ini_root, c->section_name);
                 if (c->status && push_ini && push_ini->section_balance != SECTION_BALANCE_NONE)
                         pushback_ini(&ini_root, push_ini);
                 free(c->section_name);
@@ -628,13 +621,15 @@ All parameters are optional:
             } else if (c && c->next && c->next->status >= 0) {              /* Remove a pidlist entry */
                 d = c->next;
                 c->next = d->next;
-                if (!push_ini) push_ini = getsection(ini_root, c->section_name);
+                if (!push_ini && c->section_name && c->section_name[0])
+                    push_ini = getsection(ini_root, c->section_name);
                 if (d->status && push_ini && push_ini->section_balance != SECTION_BALANCE_NONE)
                         pushback_ini(&ini_root, push_ini);
                 free(d->section_name);
                 free(d);
             } else {
-                if (!push_ini) push_ini = getsection(ini_root, c->section_name);
+                if (!push_ini && c->section_name && c->section_name[0])
+                    push_ini = getsection(ini_root, c->section_name);
                 if (push_ini && push_ini->section_balance == SECTION_BALANCE_ROUNDROBIN)
                     pushback_ini(&ini_root, push_ini);
             }
@@ -653,12 +648,18 @@ All parameters are optional:
             close(csock);
 
             /* Save the client into the list */
-            pids = pidlist_add(pids, s_ini ? s_ini->section_name : "", cpid, caddr, daddr.ip_addr);
+            pids = pidlist_add(pids, "", cpid, caddr, tmp_daddr.ip_addr);
         }
 
         if (cpid == 0) {
             /* -- Client processing (child) ------------------------------------------------------------------------- */
 
+            /* Initialize  daddr */
+            daddr_len = sizeof(daddr.ip_addr);
+            memset(&daddr.ip_addr, 0, daddr_len);
+            memset(&daddr.name, 0, sizeof(daddr.name) - 1);
+            daddr.ip_addr.ss_family = caddr.ss_family;
+
             ssock.t = CHS_SOCKET;                                       /* Type socket */
             #if (WITH_LIBSSH2)
                 ssock.c = NULL;