Fix OverloadFinder (#795)

Author: meziantou

src/Meziantou.Analyzer/Internals/OverloadFinder.cs

@@ -151,7 +151,7 @@ public static bool HasSimilarParameters(IMethodSymbol method, IMethodSymbol othe
                 break;
             }
 
-            if (i == method.Parameters.Length && j == otherMethod.Parameters.Length)
+            if (i == method.Parameters.Length && j == otherMethod.Parameters.Length && additionalParameterIndex == additionalParameterTypes.Length)
                 return true;
         }
 
@@ -162,26 +162,36 @@ public static bool HasSimilarParameters(IMethodSymbol method, IMethodSymbol othe
 
             foreach (var param in method.Parameters)
             {
+                var found = false;
                 for (var i = 0; i < otherMethodParameters.Length; i++)
                 {
                     if (otherMethodParameters[i].Type.IsEqualTo(param.Type))
                     {
                         otherMethodParameters = otherMethodParameters.RemoveAt(i);
+                        found = true;
                         break;
                     }
                 }
+
+                if (!found)
+                    return false;
             }
 
             foreach (var paramType in additionalParameterTypes)
             {
+                var found = false;
                 for (var i = 0; i < otherMethodParameters.Length; i++)
                 {
                     if (otherMethodParameters[i].Type.IsEqualTo(paramType))
                     {
                         otherMethodParameters = otherMethodParameters.RemoveAt(i);
+                        found = true;
                         break;
                     }
                 }
+
+                if (!found)
+                    return false;
             }
 
             if (otherMethodParameters.Length == 0)

tests/Meziantou.Analyzer.Test/Rules/UseAnOverloadThatHasTimeProviderAnalyzerTests.cs

@@ -29,6 +29,17 @@ await CreateProjectBuilder()
               .ValidateAsync();
     }
 
+    [Fact]
+    public async Task NoReport_TimeSpanFromSeconds()
+    {
+        const string SourceCode = """
+            _ = System.TimeSpan.FromSeconds(1);
+            """;
+        await CreateProjectBuilder()
+              .WithOutputKind(OutputKind.ConsoleApplication)
+              .WithSourceCode(SourceCode)
+              .ValidateAsync();
+    }
 
     [Fact]
     public async Task NotAvailable()