Skip to content

Commit 21d1093

Browse files
committed
Simplify EnumCodec
1 parent f94d63c commit 21d1093

File tree

5 files changed

+6
-8
lines changed

5 files changed

+6
-8
lines changed

Common/src/main/java/mezz/jei/common/codecs/EnumCodec.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,12 @@
33
import com.mojang.serialization.Codec;
44
import com.mojang.serialization.DataResult;
55

6-
import java.util.function.Function;
7-
86
public class EnumCodec {
9-
public static <T extends Enum<T>> Codec<T> create(Class<T> enumClass, Function<String, T> valueOf) {
7+
public static <T extends Enum<T>> Codec<T> create(Class<T> enumClass) {
108
return Codec.STRING.flatXmap(
119
name -> {
1210
try {
13-
T e = valueOf.apply(name);
11+
T e = Enum.valueOf(enumClass, name);
1412
return DataResult.success(e);
1513
} catch (IllegalArgumentException ignored) {
1614
return DataResult.error(() -> "Unknown enum name: '" + name + "' for enum class: " + enumClass);

Gui/src/main/java/mezz/jei/gui/config/BookmarkJsonConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class BookmarkJsonConfig implements IBookmarkConfig {
3636
private static final Logger LOGGER = LogManager.getLogger();
3737
private static final int VERSION = 2;
3838

39-
private static final Codec<BookmarkType> TYPE_CODEC = EnumCodec.create(BookmarkType.class, BookmarkType::valueOf);
39+
private static final Codec<BookmarkType> TYPE_CODEC = EnumCodec.create(BookmarkType.class);
4040
private static @Nullable MapCodec<IBookmark> BOOKMARK_CODEC;
4141

4242
@SuppressWarnings("deprecation")

Library/src/main/java/mezz/jei/library/config/EditModeConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ public FileSerializer(Path path, RegistryAccess registryAccess, ICodecHelper cod
188188
this.path = path;
189189
this.codec = RecordCodecBuilder.create(builder -> {
190190
return builder.group(
191-
EnumCodec.create(HideMode.class, HideMode::valueOf)
191+
EnumCodec.create(HideMode.class)
192192
.fieldOf("hide_mode")
193193
.forGetter(Pair::getFirst),
194194
codecHelper.getTypedIngredientCodec().codec()

Library/src/main/java/mezz/jei/library/helpers/CodecHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ private <T> Codec<T> createDefaultRecipeCategoryCodec(IRecipeManager recipeManag
129129
.forGetter(Data::registryName),
130130
getTypedIngredientCodec().codec().fieldOf("ingredient")
131131
.forGetter(Data::ingredient),
132-
EnumCodec.create(RecipeIngredientRole.class, RecipeIngredientRole::valueOf).fieldOf("ingredient_role")
132+
EnumCodec.create(RecipeIngredientRole.class).fieldOf("ingredient_role")
133133
.forGetter(Data::ingredientRole)
134134
).apply(builder, Data::new);
135135
});

Library/src/main/java/mezz/jei/library/plugins/debug/ingredients/ErrorIngredient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
public record ErrorIngredient(CrashType crashType) {
88
public static final IIngredientType<ErrorIngredient> TYPE = () -> ErrorIngredient.class;
99

10-
public static final Codec<ErrorIngredient> CODEC = EnumCodec.create(CrashType.class, CrashType::valueOf)
10+
public static final Codec<ErrorIngredient> CODEC = EnumCodec.create(CrashType.class)
1111
.xmap(ErrorIngredient::new, ErrorIngredient::crashType);
1212

1313
public enum CrashType {

0 commit comments

Comments
 (0)