Skip to content

Commit 2d509e3

Browse files
committed
Allow getting UID for empty itemstack
1 parent 4d89747 commit 2d509e3

File tree

3 files changed

+6
-17
lines changed

3 files changed

+6
-17
lines changed

Common/src/main/java/mezz/jei/common/util/ErrorUtil.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,6 @@ private static String getBlockName(BlockItem blockItem) {
8080
return block.getClass().getName();
8181
}
8282

83-
84-
@SuppressWarnings("ConstantConditions")
85-
public static void checkNotEmpty(ItemStack itemStack) {
86-
if (itemStack == null) {
87-
throw new NullPointerException("ItemStack must not be null.");
88-
} else if (itemStack.isEmpty()) {
89-
String info = getItemStackInfo(itemStack);
90-
throw new IllegalArgumentException("ItemStack value must not be empty. " + info);
91-
}
92-
}
93-
9483
@SuppressWarnings("ConstantConditions")
9584
public static void checkNotEmpty(ItemStack itemStack, String name) {
9685
if (itemStack == null) {

Common/src/main/java/mezz/jei/common/util/StackHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public boolean hasSubtypes(ItemStack stack) {
7777
}
7878

7979
public static String getRegistryNameForStack(ItemStack stack) {
80-
ErrorUtil.checkNotEmpty(stack, "stack");
80+
ErrorUtil.checkNotNull(stack, "stack");
8181

8282
Item item = stack.getItem();
8383
ResourceLocation key = RegistryUtil

Library/src/main/java/mezz/jei/library/plugins/vanilla/ingredients/ItemStackHelper.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,13 @@ public String getDisplayName(ItemStack ingredient) {
6464
@SuppressWarnings("removal")
6565
@Override
6666
public String getUniqueId(ItemStack ingredient, UidContext context) {
67-
ErrorUtil.checkNotEmpty(ingredient);
67+
ErrorUtil.checkNotNull(ingredient, "ingredient");
6868
return stackHelper.getUniqueIdentifierForStack(ingredient, context);
6969
}
7070

7171
@Override
7272
public Object getUid(ItemStack ingredient, UidContext context) {
73-
ErrorUtil.checkNotEmpty(ingredient, "ingredient");
73+
ErrorUtil.checkNotNull(ingredient, "ingredient");
7474
ErrorUtil.checkNotNull(context, "type");
7575
return stackHelper.getUidForStack(ingredient, context);
7676
}
@@ -96,13 +96,13 @@ public boolean hasSubtypes(ItemStack ingredient) {
9696
@SuppressWarnings("removal")
9797
@Override
9898
public String getWildcardId(ItemStack ingredient) {
99-
ErrorUtil.checkNotEmpty(ingredient);
99+
ErrorUtil.checkNotNull(ingredient, "ingredient");
100100
return StackHelper.getRegistryNameForStack(ingredient);
101101
}
102102

103103
@Override
104104
public String getDisplayModId(ItemStack ingredient) {
105-
ErrorUtil.checkNotEmpty(ingredient);
105+
ErrorUtil.checkNotNull(ingredient, "ingredient");
106106

107107
IPlatformItemStackHelper itemStackHelper = Services.PLATFORM.getItemStackHelper();
108108
return itemStackHelper.getCreatorModId(ingredient)
@@ -141,7 +141,7 @@ public Iterable<Integer> getColors(ItemStack ingredient) {
141141

142142
@Override
143143
public ResourceLocation getResourceLocation(ItemStack ingredient) {
144-
ErrorUtil.checkNotEmpty(ingredient);
144+
ErrorUtil.checkNotNull(ingredient, "ingredient");
145145

146146
Item item = ingredient.getItem();
147147
ResourceLocation key = RegistryUtil

0 commit comments

Comments
 (0)