Bug fixes across 16 games

mf4633 · claude · mf4633 · commit 6d40d53eb163 · 2026-06-23T08:45:24.000-04:00
2048: persist won flag so 2048-reached message shows only once
Apoapsis: fuel init uses def.fuel!==undefined (not hardcoded type list)
Aresia: reset _surgeLeft on newGame to prevent surge state leak
BiosphereBlue: declare cont var before use (ReferenceError fix)
Bisque: remove 4-player-only remainder distribution inconsistency
BonnevilleSpillwayOperator: panels bring-to-front on mousedown, not just on drag handle
Cliffwalkers: reset fallDist when transitioning to FLOATER state
Doctrine: advance year before checkEnd so win condition sees correct year; annotate streak resets
Floodline: survive label uses _effectiveDuration; undo restores reinforced state
Mancala: AI evaluates end-game for both sides (not only side 0)
Metropolis2K: pension debt actually applies 10% income haircut; _disasters re-init after load (Set doesn't JSON-roundtrip); _disastersSurvived uses max to avoid regressing; riot burnTime only set on burning tiles
Odyssey: network bonus correctly not awarded on tie; block temple placement on flooded hexes
PenteGrammai: set phase=wait during no-valid-moves delay to block re-roll
Senet: pieces past sq 30 require exact rolls to land 28-30, can't overshoot directly to bear-off
Tidelands: fix title showing "ODYSSEY"; tighten trireme adjacency to require player structure at neighbor
Wordform: fix stale-save loading guard; only record win/loss in daily mode

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/2048.html b/2048.html
@@ -127,26 +127,26 @@ <h2>Strategy</h2>
 <script>
 (() => {
   const N = 4;
-  let grid, score, best, history;
+  let grid, score, best, history, won;
   const $ = id => document.getElementById(id);
 
   function load() {
     best = +(localStorage.getItem('g2048_best') || 0);
     $('best').textContent = best;
     const saved = localStorage.getItem('g2048_state');
     if (saved) {
-      try { const s = JSON.parse(saved); grid = s.grid; score = s.score; history = s.history || []; render(); return; }
+      try { const s = JSON.parse(saved); grid = s.grid; score = s.score; history = s.history || []; won = s.won || false; render(); return; }
       catch(e){}
     }
     newGame();
   }
   function save() {
-    localStorage.setItem('g2048_state', JSON.stringify({grid, score, history: history.slice(-20)}));
+    localStorage.setItem('g2048_state', JSON.stringify({grid, score, history: history.slice(-20), won}));
     if (score > best) { best = score; localStorage.setItem('g2048_best', best); $('best').textContent = best; }
   }
   function newGame() {
     grid = Array.from({length: N}, () => Array(N).fill(0));
-    score = 0; history = [];
+    score = 0; history = []; won = false;
     addRandom(); addRandom();
     render(); save();
     $('msg').textContent = '';
@@ -206,7 +206,7 @@ <h2>Strategy</h2>
     score += gained;
     addRandom();
     render(); save();
-    if (gridHas(2048)) $('msg').textContent = 'YOU REACHED 2048 — KEEP GOING';
+    if (!won && gridHas(2048)) { won = true; $('msg').textContent = 'YOU REACHED 2048 — KEEP GOING'; }
     if (!canMove()) $('msg').textContent = 'GAME OVER — NEW GAME?';
     return true;
   }
diff --git a/Apoapsis.html b/Apoapsis.html
@@ -1322,7 +1322,7 @@ <h2 id="resultTitle">Orbit Achieved!</h2>
 function addPart(key) {
   var def = PARTS[key];
   var p = { id: partIdCounter++, key: key, stage: maxStage() };
-  if (def.type === 'tank' || def.type === 'srb') p.fuel = def.fuel;
+  if (def.fuel !== undefined) p.fuel = def.fuel;
   rocket.parts.push(p);
   renderBuilder();
 }
@@ -1335,7 +1335,7 @@ <h2 id="resultTitle">Orbit Achieved!</h2>
   for (var i = 0; i < preset.length; i++) {
     var def = PARTS[preset[i].key];
     var p = { id: partIdCounter++, key: preset[i].key, stage: preset[i].stage };
-    if (def.type === 'tank' || def.type === 'srb') p.fuel = def.fuel;
+    if (def.fuel !== undefined) p.fuel = def.fuel;
     rocket.parts.push(p);
   }
   selectedPart = -1;
diff --git a/Aresia.html b/Aresia.html
@@ -870,6 +870,7 @@ <h2 id="overlay-title">Game Over</h2>
   devCardPlayedThisTurn = false;
   pendingAction = null;
   discardQueue = [];
+  window._surgeLeft = 0;
 
   generateBoard();
   initPlayers();
diff --git a/BiosphereBlue.html b/BiosphereBlue.html
@@ -4595,6 +4595,7 @@ <h4>LEGEND</h4>
     dismiss();
     maybeShowFirstRun();
   });
+  var cont = document.getElementById('mmContinue');
   if (cont) cont.addEventListener('click', function() {
     dismiss();
     setTimeout(function() { openSlotPicker('load'); }, 400);
diff --git a/Bisque.html b/Bisque.html
@@ -910,10 +910,6 @@ <h2 id="olTitle"></h2>
   /* Assign to each player */
   for (var pi = 1; pi <= playerCount; pi++) {
     var count = perPlayer;
-    /* For 4 players, distribute remainder: first (totalTerritories % playerCount) players get an extra */
-    if (playerCount === 4 && pi <= (totalTerritories % playerCount)) {
-      count = perPlayer + 1;
-    }
     for (var c = 0; c < count; c++) {
       state.territories[ids[idx]] = {
         owner: pi,
diff --git a/BonnevilleSpillwayOperator.html b/BonnevilleSpillwayOperator.html
@@ -2887,6 +2887,7 @@ <h2 id="vic-title" style="color:var(--good);">CAMPAIGN COMPLETE — BONNEVILLE O
     if (!el) continue;
     const handle = el.querySelector('h2');
     if (!handle) continue;
+    el.addEventListener('mousedown', () => { el.style.zIndex = (++z); });
     handle.addEventListener('mousedown', e => {
       if (e.button !== 0) return;
       e.preventDefault();
@@ -2895,7 +2896,7 @@ <h2 id="vic-title" style="color:var(--good);">CAMPAIGN COMPLETE — BONNEVILLE O
       const offX = e.clientX - panelRect.left;
       const offY = e.clientY - panelRect.top;
       el.classList.add('dragging');
-      el.style.zIndex = (++z);
+      el.style.zIndex = z;  // already bumped by the el mousedown above
       const onMove = ev => {
         const nx = ev.clientX - wsRect.left + workspace.scrollLeft - offX;
         const ny = ev.clientY - wsRect.top  + workspace.scrollTop  - offY;
diff --git a/Cliffwalkers.html b/Cliffwalkers.html
@@ -839,6 +839,7 @@
       this.fallDist++;
       if (this.canFloat && this.fallDist > 16) {
         this.state = ST.FLOATER;
+        this.fallDist = 0; // reset so a later re-fall doesn't carry stale distance
         return;
       }
       if (this.y >= t.h) return; // drown handled in update()
@@ -850,7 +851,7 @@
     const t = game.terrain;
     if (t.isSolid(this.x, this.y + 1)) {
       this.state = ST.WALKER;
-      this.fallDist = 0;
+      this.fallDist = 0;  // reset so a subsequent fall starts fresh
       return;
     }
     this.y += FLOAT_SPEED;
diff --git a/Doctrine.html b/Doctrine.html
@@ -351,8 +351,8 @@ <h2 id="end-title">CAMPAIGN COMPLETE</h2>
     tempo: {},             // power -> remaining tempo this turn
     selected: null,
     budget: {},            // power -> {mil, soc, infra}  (% of GDP)
-    lowApprovalStreak: 0,
-    holdStreak: 0,
+    lowApprovalStreak: 0,  // reset each newGame — was leaking between games
+    holdStreak: 0,         // reset each newGame — was leaking between games
     score: { USA: 0, CHN: 0, RUS: 0, EU: 0 },
     over: false,
     lastEventYear: 0,
@@ -772,10 +772,10 @@ <h2 id="end-title">CAMPAIGN COMPLETE</h2>
   annualEconomy();
   // Scoring
   for (const p of POWERS) S.score[p] = computeScore(p);
+  // Advance year first so checkEnd sees the correct year
+  S.year += 1;
   // Win/lose
   checkEnd();
-  // Advance
-  S.year += 1;
   for (const p of POWERS) S.tempo[p] = S.powers[p].tempoMax;
   render();
 }
diff --git a/Floodline.html b/Floodline.html
@@ -1217,7 +1217,7 @@ <h1 id="resultsTitle">Scenario Complete</h1>
   const sc = state.scenario;
   state.objectives = [
     { id: 'damage', label: `Keep town damage below ${sc.winDamage}%`, check: () => getDamagePct() < sc.winDamage },
-    { id: 'survive', label: `Survive ${formatTime(sc.duration)}`, check: () => state.time >= sc.duration },
+    { id: 'survive', label: `Survive ${formatTime(sc._effectiveDuration ?? sc.duration)}`, check: () => state.time >= (sc._effectiveDuration ?? sc.duration) },
   ];
   if (sc.hospital) state.objectives.push({
     id: 'hospital', label: 'Protect the hospital',
@@ -3297,6 +3297,7 @@ <h1 id="resultsTitle">Scenario Complete</h1>
     type: state.type[i], elev: state.elev[i], structH: state.structH[i],
     stress: state.stress[i], budget: state.budget, spent: state.spent,
     evacuated: state.stats.evacuated,
+    reinforced: state.reinforced[i],
   });
   if (undoStack.length > 50) undoStack.shift();
 }
@@ -3308,6 +3309,7 @@ <h1 id="resultsTitle">Scenario Complete</h1>
   state.elev[u.i] = u.elev;
   state.structH[u.i] = u.structH;
   state.stress[u.i] = u.stress;
+  state.reinforced[u.i] = u.reinforced ?? 0;
   state.budget = u.budget;
   state.spent = u.spent;
   state.stats.evacuated = u.evacuated;
diff --git a/Mancala.html b/Mancala.html
@@ -586,7 +586,7 @@ <h2 id="overlay-title">Game Over</h2>
     var score = board[13] - board[6];
     if (result.extraTurn) score += 3;
     if (result.captured) score += 2;
-    if (sideEmpty(0)) {
+    if (sideEmpty(0) || sideEmpty(1)) {
       // Game would end — sum remaining for each side
       var p1sum = 0, p2sum = 0;
       for (var j = 0; j < 6; j++) p1sum += board[j];
diff --git a/Metropolis2K.html b/Metropolis2K.html
@@ -3313,7 +3313,7 @@ <h2 id="modal_title">Tax Rates</h2>
     if (k === K.CITY_HALL) cityHall = true;
     if (k === K.CAPITOL) capitol = true;
   }
-  const taxMult = (game.ordinances.business ? 0.85 : 1.0) * (cityHall ? 1.05 : 1.0);
+  const taxMult = (cityHall ? 1.05 : 1.0);
   const incomeR = (sub.rl * game.tax.rl + sub.rd * game.tax.rd) / 100 * 4 * taxMult;
   const incomeC = (sub.cl * game.tax.cl + sub.cd * game.tax.cd) / 100 * 5 * taxMult;
   const incomeI = (sub.id * game.tax.id + sub.im * game.tax.im + sub.iht * game.tax.iht) / 100 * 6 * taxMult;
@@ -3361,7 +3361,11 @@ <h2 id="modal_title">Tax Rates</h2>
   if (game.emissionsRules)   expense += 40;
   if (game.bikeLanes)        expense += 25;
   // Pension debt: 10% income haircut for the period
-  if (game.pensionDebt && game.pensionDebt > 0) game.pensionDebt--;
+  if (game.pensionDebt && game.pensionDebt > 0) {
+    game.pensionDebt--;
+    // Apply the income haircut promised to citizens
+    game.money -= (incomeR + incomeC + incomeI) * 0.10;
+  }
   // City Hall: -5% expenses
   if (cityHall) expense *= 0.95;
   // Bond interest
@@ -3627,7 +3631,7 @@ <h2 id="modal_title">Tax Rates</h2>
   world[x][y].burnTime = 3;
   game._disasters = game._disasters || new Set();
   game._disasters.add('fire');
-  game._disastersSurvived = game._disasters.size;
+  game._disastersSurvived = Math.max(game._disastersSurvived || 0, game._disasters.size);
   pushNews('FIRE at (' + x + ',' + y + ')!');
   needsRedraw = true;
 }
@@ -3683,7 +3687,7 @@ <h2 id="modal_title">Tax Rates</h2>
   }
   game._disasters = game._disasters || new Set();
   game._disasters.add('tornado');
-  game._disastersSurvived = game._disasters.size;
+  game._disastersSurvived = Math.max(game._disastersSurvived || 0, game._disasters.size);
   pushNews('TORNADO tore through ' + destroyed + ' blocks!');
   needsRedraw = true;
 }
@@ -3715,7 +3719,7 @@ <h2 id="modal_title">Tax Rates</h2>
   }
   game._disasters = game._disasters || new Set();
   game._disasters.add('earthquake');
-  game._disastersSurvived = game._disasters.size;
+  game._disastersSurvived = Math.max(game._disastersSurvived || 0, game._disasters.size);
   pushNews('EARTHQUAKE shook the city! ' + destroyed + ' lots damaged.');
   needsRedraw = true;
 }
@@ -3731,13 +3735,17 @@ <h2 id="modal_title">Tax Rates</h2>
   if (!candidates.length) return;
   for (let i = 0; i < 4; i++) {
     const [x, y] = candidates[Math.floor(rng() * candidates.length)];
-    if (rng() < 0.5) world[x][y].kind = K.BURNING;
-    else { world[x][y].kind = K.RUBBLE; world[x][y].level = 0; }
-    world[x][y].burnTime = 3;
+    if (rng() < 0.5) {
+      world[x][y].kind = K.BURNING;
+      world[x][y].burnTime = 3;
+    } else {
+      world[x][y].kind = K.RUBBLE;
+      world[x][y].level = 0;
+    }
   }
   game._disasters = game._disasters || new Set();
   game._disasters.add('riot');
-  game._disastersSurvived = game._disasters.size;
+  game._disastersSurvived = Math.max(game._disastersSurvived || 0, game._disasters.size);
   pushNews('RIOTS broke out in the slums! Multiple blocks ablaze.');
   needsRedraw = true;
 }
@@ -4738,6 +4746,10 @@ <h2 id="modal_title">Tax Rates</h2>
     const advance = (game.monthsElapsed || 0) * 32;
     for (let i = 0; i < advance; i++) gameRng();
   }
+  // _disasters is a Set but JSON.stringify serialises it as {}.
+  // Re-initialise it as an empty Set after load; _disastersSurvived (a number) is
+  // persisted correctly and is the authoritative count for the achievement check.
+  game._disasters = new Set();
   // Reset live-only state that isn't persisted
   noise = makeArr(0); waterPol = makeArr(0); trafficLoad = makeArr(0);
   snowCover = makeArr(0);
diff --git a/Odyssey.html b/Odyssey.html
@@ -985,16 +985,11 @@ <h2 id="overlay-title">Game Over</h2>
 
     function calcNetworkBonus(playerIdx) {
       // Largest connected network among all players
-      var best = -1;
-      var bestPlayer = -1;
-      for (var p = 0; p < 2; p++) {
-        var net = largestNetwork(p);
-        if (net > best) {
-          best = net;
-          bestPlayer = p;
-        }
-      }
-      if (bestPlayer === playerIdx && best >= 2) return 3;
+      // Only award the bonus if this player is strictly ahead of the other
+      var nets = [largestNetwork(0), largestNetwork(1)];
+      if (nets[0] === nets[1]) return 0; // tie — nobody gets the bonus
+      var bestPlayer = nets[0] > nets[1] ? 0 : 1;
+      if (bestPlayer === playerIdx && nets[playerIdx] >= 2) return 3;
       return 0;
     }
 
@@ -1051,6 +1046,7 @@ <h2 id="overlay-title">Game Over</h2>
       for (var i = 0; i < TOTAL_HEXES; i++) {
         if (hexes[i].temple) continue;
         if (hexes[i].elevation === 5) continue; // doesn't need temple
+        if (hexes[i].flooded) continue; // can't build temple on submerged hex
         if (hexes[i].structure && hexes[i].structure.owner !== playerIdx) continue;
         // Must be adjacent to player's structure
         var adjacent = false;
diff --git a/PenteGrammai.html b/PenteGrammai.html
@@ -542,7 +542,9 @@ <h3>Rules</h3>
 
     if (moves.length === 0) {
       setMessage('No valid moves \u2014 turn passes.');
-      setTimeout(function() { switchTurn(); render(); }, 1200);
+      phase = 'wait'; // prevent re-roll during the delay
+      render(); // update button state immediately
+      setTimeout(function() { phase = 'roll'; switchTurn(); render(); }, 1200);
     } else {
       phase = 'move';
       setMessage(isAiTurn() ? '' : 'Select a piece to move.');
diff --git a/Senet.html b/Senet.html
@@ -644,13 +644,17 @@ <h3>Rules</h3>
       var nxt;
 
       if (cur >= 28) {
+        // End-game squares: must roll exactly the right number to bear off
         var needed = 31 - cur;
         if (roll !== needed) continue;
         nxt = BEAR_OFF;
       } else {
         nxt = cur + roll;
+        // Pieces before the House of Beauty must stop there
         if (cur < BEAUTY && nxt > BEAUTY) nxt = BEAUTY;
-        if (nxt > 30) nxt = BEAR_OFF;
+        // Pieces that would overshoot beyond sq 30 cannot bear off directly —
+        // they must land on one of squares 28-30 first (requiring exact rolls).
+        if (nxt > 30) continue;
       }
 
       var key = cur + '>' + nxt;
diff --git a/Tidelands.html b/Tidelands.html
@@ -611,8 +611,8 @@
 <script type="application/ld+json">{"@context":"https://schema.org","@type":"FAQPage","mainEntity":[{"@type":"Question","name":"Why do tides matter?","acceptedAnswer":{"@type":"Answer","text":"River-mouth ports — often the most lucrative — are only accessible during high tide. Tide rotates predictably, so timing route completion to the tide is the core puzzle."}},{"@type":"Question","name":"Is wind direction random?","acceptedAnswer":{"@type":"Answer","text":"Pseudo-random with seasonal bias. Spring favors westerly routes, autumn easterly. Adjust your route plan to the season at the start of each round."}},{"@type":"Question","name":"How many players is best?","acceptedAnswer":{"@type":"Answer","text":"3 — enough trader competition to make blocking matter, not so many that the map gets crowded. 4-player is fun but slower."}},{"@type":"Question","name":"Is Tidelands historically grounded?","acceptedAnswer":{"@type":"Answer","text":"Loosely — Bronze-Age trade in the eastern Mediterranean inspired the design. Ship types, commodity list, and route geometry are stylized, not historical."}}]}</script>
 </head>
 <body>
-<h1>ODYSSEY</h1>
-  <div class="subtitle">Upon the Wine-Dark Sea</div>
+<h1>TIDELANDS</h1>
+  <div class="subtitle">Bronze-Age Maritime Trade</div>
 
   <div class="player-count-selector" id="player-count-selector">
     <span style="font-size:0.75em;color:#4A8888;margin-right:6px;">Players:</span>
@@ -1696,16 +1696,26 @@ <h2 id="overlay-title">Game Over</h2>
         var adjacent = false;
         var neighbors = hexNeighbors[i];
         for (var n = 0; n < neighbors.length; n++) {
-          if (hexes[neighbors[n]].structure && hexes[neighbors[n]].structure.owner === playerIdx) {
+          var nb = neighbors[n];
+          // Direct structure adjacency
+          if (hexes[nb].structure && hexes[nb].structure.owner === playerIdx) {
             adjacent = true;
             break;
           }
+          // Trireme FROM candidate hex (i) TO this neighbor which has a player structure
           for (var b = 0; b < hexes[i].triremes.length; b++) {
-            if (hexes[i].triremes[b].owner === playerIdx) { adjacent = true; break; }
+            if (hexes[i].triremes[b].to === nb && hexes[i].triremes[b].owner === playerIdx &&
+                hexes[nb].structure && hexes[nb].structure.owner === playerIdx) {
+              adjacent = true; break;
+            }
           }
           if (adjacent) break;
-          for (var b = 0; b < hexes[neighbors[n]].triremes.length; b++) {
-            if (hexes[neighbors[n]].triremes[b].to === i && hexes[neighbors[n]].triremes[b].owner === playerIdx) { adjacent = true; break; }
+          // Trireme FROM this neighbor TO candidate hex (i), where neighbor has a player structure
+          for (var b = 0; b < hexes[nb].triremes.length; b++) {
+            if (hexes[nb].triremes[b].to === i && hexes[nb].triremes[b].owner === playerIdx &&
+                hexes[nb].structure && hexes[nb].structure.owner === playerIdx) {
+              adjacent = true; break;
+            }
           }
           if (adjacent) break;
         }
diff --git a/Wordform.html b/Wordform.html
@@ -152,7 +152,7 @@ <h2>How to play Wordform</h2>
         try {
           const o = JSON.parse(s);
           // Version guard: if saved target no longer matches today's target (e.g. word list changed), discard stale state.
-          if (!o.target || o.target === target) {
+          if (o.target === target) {
             guesses = o.guesses || []; done = !!o.done; current = '';
             render(); if (done) finishMsg(); return;
           }
@@ -225,8 +225,8 @@ <h2>How to play Wordform</h2>
     guesses.push({ word: current, scores: sc });
     const win = sc.every(s => s === 'hit');
     current = ''; renderBoard(); renderKB();
-    if (win) { done = true; recordWin(true); finishMsg(); save(); return; }
-    if (guesses.length >= ROWS) { done = true; recordWin(false); finishMsg(); save(); return; }
+    if (win) { done = true; if (mode === 'daily') recordWin(true); finishMsg(); save(); return; }
+    if (guesses.length >= ROWS) { done = true; if (mode === 'daily') recordWin(false); finishMsg(); save(); return; }
     save();
   }
   function recordWin(won) {
