Merge pull request demarche-numerique#12511 from mfo/US/perf-api

amelioration API: demarche ac 246 champs conditionnels sur 312

Author: mfo

app/models/concerns/champ_conditional_concern.rb

@@ -34,12 +34,21 @@ def submitted_filled?
 
     def reset_visible # recompute after a dossier update
       remove_instance_variable :@visible if instance_variable_defined? :@visible
+      remove_instance_variable :@champs_for_condition if instance_variable_defined? :@champs_for_condition
     end
 
     private
 
     def champs_for_condition
-      dossier.filled_champs.filter { _1.row_id.nil? || _1.row_id == row_id }
+      if row_id.nil?
+        Array(filled_champs_by_row_id[nil])
+      else
+        Array(filled_champs_by_row_id[row_id]) + Array(filled_champs_by_row_id[nil])
+      end
+    end
+
+    def filled_champs_by_row_id
+      @filled_champs_by_row_id ||= dossier.filled_champs.group_by(&:row_id)
     end
 
     def parent_hidden?

app/models/procedure_revision_type_de_champ.rb

@@ -14,14 +14,19 @@ class ProcedureRevisionTypeDeChamp < ApplicationRecord
   scope :public_only, -> { joins(:type_de_champ).where(types_de_champ: { private: false }) }
   scope :private_only, -> { joins(:type_de_champ).where(types_de_champ: { private: true }) }
 
-  delegate :stable_id, :libelle, :description, :type_champ, :header_section?, :repetition?, :mandatory?, :public?, :private?, :to_typed_id, to: :type_de_champ
+  delegate :libelle, :description, :type_champ, :header_section?, :repetition?, :mandatory?, :public?, :private?, :to_typed_id, to: :type_de_champ
   delegate :type_de_champ, to: :parent, prefix: true, allow_nil: true
 
   default_scope { eager_load(:type_de_champ) }
 
   def revision_types_de_champ = revision.revision_types_de_champ.filter { _1.persisted? ? _1.parent_id == id : _1.parent == self }.sort_by(&:position)
   def types_de_champ = revision_types_de_champ.map(&:type_de_champ)
 
+  # significant perf gain when accessed hundreds of thousands of times in API or export context
+  def stable_id
+    @stable_id ||= type_de_champ.stable_id
+  end
+
   def root?
     persisted? ? parent_id.nil? : parent.nil?
   end

lib/tasks/benchmarks.rake

@@ -41,6 +41,41 @@ namespace :benchmarks do
     end
   end
 
+  desc 'graphql query - quick benchmark'
+  task graphql_quick: :environment do
+    query = API::V2::StoredQuery::QUERY_V2
+
+    procedure = Procedure.find(ENV.fetch('PROCEDURE_ID', 107325).to_i)
+    administrateur = procedure.administrateurs.first
+
+    variables = { "demarcheNumber": procedure.id, "includeDossiers": true, "first": 20 }
+    context = {
+      administrateur_id: administrateur.id,
+      procedure_ids: administrateur.procedure_ids,
+      write_access: true,
+    }
+    operation_name = 'getDemarche'
+
+    Rails.application.routes.default_url_options[:only_path] = true
+
+    # Nombre d'itérations depuis env ou 1 par défaut
+    iterations = ENV.fetch('ITERATIONS', 1).to_i
+
+    # Warmup
+    puts "Warmup..."
+    API::V2::Schema.execute(query:, variables:, context:, operation_name:)
+
+    puts "\nRunning #{iterations} iterations..."
+
+    Benchmark.bm(30) do |x|
+      x.report("GraphQL API (#{iterations}x):") do
+        iterations.times do
+          API::V2::Schema.execute(query:, variables:, context:, operation_name:)
+        end
+      end
+    end
+  end
+
   # Benchmark une action Rails spécifique, y compris le temps de génération des views.
   # Optionnellement, compare avec une autre implémentation de l’action
   # sur la même branche ou sur deux branches git.