Successful tests with panic show PANIC status

[rodrigozhou]

tparse is reporting PANIC status for a test that does have a panic, but it's expected and the panic is being handled in the code and not throwing another panic. The test itself has a PASS status from the go test output, so I'd expect tparse to report the test as PASS.

[mfridman]

Any chance you could provide a minimal reproducible example? Either that or the raw JSON output would help a lot.

[mfridman]

Would it be possible to avoid using panic: as test output in your tests? Maybe prefix them with myapp: panic: to differentiate with the standard library panic output?

[rodrigozhou]

This is from the repo https://github.com/temporalio/temporal.
You can repro by running go test -v -json ./service/history/replication -run TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured | tparse -all

Here's the raw json:

{"Time":"2025-09-09T11:21:23.522564-07:00","Action":"start","Package":"go.temporal.io/server/service/history/replication"}
{"Time":"2025-09-09T11:21:23.522664-07:00","Action":"run","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite"}
{"Time":"2025-09-09T11:21:23.522685-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite","Output":"=== RUN   TestStreamReceiverSuite\n"}
{"Time":"2025-09-09T11:21:23.522702-07:00","Action":"run","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured"}
{"Time":"2025-09-09T11:21:23.522707-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"=== RUN   TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured\n"}
{"Time":"2025-09-09T11:21:23.522722-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"2025-09-09T11:21:01.477-0700\terror\tPanic is captured\t{\"xdc-source-cluster\": \"some-cluster-name\", \"xdc-source-shard-id\": 63380910, \"shard-id\": 1411736200, \"operation\": \"replication-stream-receiver\", \"sys-stack-trace\": \"goroutine 24 [running]:\\nruntime/debug.Stack()\\n\\t/opt/homebrew/Cellar/go/1.25.0/libexec/src/runtime/debug/stack.go:26 +0x64\\ngo.temporal.io/server/common/log.CapturePanic({0x102f2bb20, 0x140009c4390}, 0x14000941610)\\n\\t/Users/rodrigozhou/repos/temporalio/temporal/common/log/panic.go:22 +0xe0\\npanic({0x10294b1e0?, 0x1047815f0?})\\n\\t/opt/homebrew/Cellar/go/1.25.0/libexec/src/runtime/panic.go:783 +0x120\\ngo.temporal.io/server/service/history/replication.(*StreamReceiverImpl).sendEventLoop(0x14000171520)\\n\\t/Users/rodrigozhou/repos/temporalio/temporal/service/history/replication/stream_receiver.go:171 +0x90\\ngo.temporal.io/server/service/history/replication.(*streamReceiverSuite).TestSendEventLoop_Panic_Captured(0x0?)\\n\\t/Users/rodrigozhou/repos/temporalio/temporal/service/history/replication/strea"}
{"Time":"2025-09-09T11:21:23.522773-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"m_receiver_test.go:502 +0x20\\nreflect.Value.call({0x140009648c0?, 0x140000b5228?, 0x1400090e3a8?}, {0x1021a1cd8, 0x4}, {0x14000941f20, 0x1, 0x101f68954?})\\n\\t/opt/homebrew/Cellar/go/1.25.0/libexec/src/reflect/value.go:581 +0x960\\nreflect.Value.Call({0x140009648c0?, 0x140000b5228?, 0x103e769d8?}, {0x14000941f20?, 0x103e769d8?, 0x100a6f423?})\\n\\t/opt/homebrew/Cellar/go/1.25.0/libexec/src/reflect/value.go:365 +0x94\\ngithub.com/stretchr/testify/suite.Run.func1(0x140009a4380)\\n\\t/Users/rodrigozhou/go/pkg/mod/github.com/stretchr/testify@v1.10.0/suite/suite.go:202 +0x344\\ntesting.tRunner(0x140009a4380, 0x140005798c0)\\n\\t/opt/homebrew/Cellar/go/1.25.0/libexec/src/testing/testing.go:1934 +0xc8\\ncreated by testing.(*T).Run in goroutine 23\\n\\t/opt/homebrew/Cellar/go/1.25.0/libexec/src/testing/testing.go:1997 +0x364\\n\", \"error\": \"runtime error: invalid memory address or nil pointer dereference\", \"logging-call-at\": \"/Users/rodrigozhou/repos/temporalio/temporal/common/log/panic.go:24\"}\n"}
{"Time":"2025-09-09T11:21:23.522835-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"go.temporal.io/server/common/log.(*zapLogger).Error\n"}
{"Time":"2025-09-09T11:21:23.522839-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"\t/Users/rodrigozhou/repos/temporalio/temporal/common/log/zap_logger.go:151\n"}
{"Time":"2025-09-09T11:21:23.522841-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"go.temporal.io/server/common/log.CapturePanic\n"}
{"Time":"2025-09-09T11:21:23.522843-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"\t/Users/rodrigozhou/repos/temporalio/temporal/common/log/panic.go:24\n"}
{"Time":"2025-09-09T11:21:23.522891-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"runtime.gopanic\n"}
{"Time":"2025-09-09T11:21:23.522897-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"\t/opt/homebrew/Cellar/go/1.25.0/libexec/src/runtime/panic.go:783\n"}
{"Time":"2025-09-09T11:21:23.522899-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"runtime.panicmem\n"}
{"Time":"2025-09-09T11:21:23.522901-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"\t/opt/homebrew/Cellar/go/1.25.0/libexec/src/runtime/panic.go:262\n"}
{"Time":"2025-09-09T11:21:23.522903-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"runtime.sigpanic\n"}
{"Time":"2025-09-09T11:21:23.522919-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"\t/opt/homebrew/Cellar/go/1.25.0/libexec/src/runtime/signal_unix.go:925\n"}
{"Time":"2025-09-09T11:21:23.522921-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"go.temporal.io/server/service/history/replication.(*StreamReceiverImpl).sendEventLoop\n"}
{"Time":"2025-09-09T11:21:23.522925-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"\t/Users/rodrigozhou/repos/temporalio/temporal/service/history/replication/stream_receiver.go:171\n"}
{"Time":"2025-09-09T11:21:23.522955-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"go.temporal.io/server/service/history/replication.(*streamReceiverSuite).TestSendEventLoop_Panic_Captured\n"}
{"Time":"2025-09-09T11:21:23.522962-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"\t/Users/rodrigozhou/repos/temporalio/temporal/service/history/replication/stream_receiver_test.go:502\n"}
{"Time":"2025-09-09T11:21:23.522965-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"reflect.Value.call\n"}
{"Time":"2025-09-09T11:21:23.522967-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"\t/opt/homebrew/Cellar/go/1.25.0/libexec/src/reflect/value.go:581\n"}
{"Time":"2025-09-09T11:21:23.522989-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"reflect.Value.Call\n"}
{"Time":"2025-09-09T11:21:23.522993-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"\t/opt/homebrew/Cellar/go/1.25.0/libexec/src/reflect/value.go:365\n"}
{"Time":"2025-09-09T11:21:23.523-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"github.com/stretchr/testify/suite.Run.func1\n"}
{"Time":"2025-09-09T11:21:23.523003-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"\t/Users/rodrigozhou/go/pkg/mod/github.com/stretchr/testify@v1.10.0/suite/suite.go:202\n"}
{"Time":"2025-09-09T11:21:23.52303-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"testing.tRunner\n"}
{"Time":"2025-09-09T11:21:23.523092-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"\t/opt/homebrew/Cellar/go/1.25.0/libexec/src/testing/testing.go:1934\n"}
{"Time":"2025-09-09T11:21:23.523124-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite","Output":"--- PASS: TestStreamReceiverSuite (0.00s)\n"}
{"Time":"2025-09-09T11:21:23.523131-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Output":"    --- PASS: TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured (0.00s)\n"}
{"Time":"2025-09-09T11:21:23.523134-07:00","Action":"pass","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite/TestSendEventLoop_Panic_Captured","Elapsed":0}
{"Time":"2025-09-09T11:21:23.523138-07:00","Action":"pass","Package":"go.temporal.io/server/service/history/replication","Test":"TestStreamReceiverSuite","Elapsed":0}
{"Time":"2025-09-09T11:21:23.52314-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Output":"PASS\n"}
{"Time":"2025-09-09T11:21:23.523146-07:00","Action":"output","Package":"go.temporal.io/server/service/history/replication","Output":"ok  \tgo.temporal.io/server/service/history/replication\t(cached)\n"}
{"Time":"2025-09-09T11:21:23.523157-07:00","Action":"pass","Package":"go.temporal.io/server/service/history/replication","Elapsed":0.001}

[rodrigozhou]

Would it be possible to avoid using panic: as test output in your tests? Maybe prefix them with myapp: panic: to differentiate with the standard library panic output?

Actually, there isn't panic: string in this output.

[mfridman]

Yeah alright, I see that output has a runtime error: string that we match on. I'll double-check this logic and compare it against what the Go standard library does.

Likely need to improve the logic for capturing panics. Will mark this as a bug, appreciate the reproducible example.

[rodrigozhou]

I took a quick look at the tparse code, and I think it has this bug mainly because you added the PANIC status to the test result, which is not a actual status from the go test output.

If you just remove the PANIC status, and report it as FAIL as you do for other failures, it would make things simpler maybe? FWIW, I don't mind seeing FAIL instead of PANIC as long as I can see in the logs that the panic happened.

Anyway, just my quick thoughts after looking at parse/process.go for 5 minutes...