Added the disass-style command to the debugger
#2907
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command will set the disassembler to either output decimal or hex representations of immediates. This is to make disassembly more clear so you don't have to convert values in a different tool.
|
First off: your editor appears to use soft tabs. Please use hard tabs to avoid causing reindentation issues. Second: please use |
endrift
requested changes
Apr 29, 2023
Co-authored-by: Vicki Pfau <[email protected]>
endrift
requested changes
May 3, 2023
| } else { | ||
| written = snprintf(buffer, blen, "$%02X", op.immediate); | ||
| if(disassemblyStyle == DISASSEMBLY_STYLE_HEX) { |
There was a problem hiding this comment.
Suggested change
| if(disassemblyStyle == DISASSEMBLY_STYLE_HEX) { | |
| if (disassemblyStyle == DISASSEMBLY_STYLE_HEX) { |
| @@ -45,6 +47,15 @@ static const char* _armConditions[] = { | |||
| "nv" | |||
| }; | |||
|
|
|||
| static int _decodeImmediate(int imm, enum mDisassemblyStyle disassemblyStyle, char* buffer, int blen) { | |||
| switch(disassemblyStyle) { | |||
There was a problem hiding this comment.
Suggested change
| switch(disassemblyStyle) { | |
| switch (disassemblyStyle) { |
Also, I meant having both the default and explicit cases separately listed, but it should probably be done with an if/else like you have in the SM83 implementation.
| if (disassemblyStyle == DISASSEMBLY_STYLE_HEX) { | ||
| written = snprintf(buffer, blen, "$%04X", pc + (int8_t) op.immediate); | ||
| } else { | ||
| written = snprintf(buffer, blen, "%05i", pc + (int8_t) op.immediate); |
There was a problem hiding this comment.
Suggested change
| written = snprintf(buffer, blen, "%05i", pc + (int8_t) op.immediate); | |
| written = snprintf(buffer, blen, "%i", pc + (int8_t) op.immediate); |
| if(disassemblyStyle == DISASSEMBLY_STYLE_HEX) { | ||
| written = snprintf(buffer, blen, "$%02X", pc + (int8_t) op.immediate); | ||
| } else { | ||
| written = snprintf(buffer, blen, "%03i", pc + (int8_t) op.immediate); |
There was a problem hiding this comment.
Suggested change
| written = snprintf(buffer, blen, "%03i", pc + (int8_t) op.immediate); | |
| written = snprintf(buffer, blen, "%i", pc + (int8_t) op.immediate); |
|
Any updates on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command will set the disassembler to either output decimal or hex representations of immediates. This is to make disassembly more clear so you don't have to convert values in a different tool. The command works on both ARM and sm83 code. This commit was originally made to solve #2553. Unfortunately that issue was actually invalid. However I already had the functionality of changing between decimal and hex for immediates implemented, so I added a command that would control it.