Skip to content

Commit f6dad4b

Browse files
committed
UPV Visualization for Arm/Leg Guides in Component Guide Mode
MISC updates WIP. Planning to change the logic under a new method self.add_upv_vis #567
1 parent 78d96a6 commit f6dad4b

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

release/scripts/mgear/core/upv_visualizer.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -346,18 +346,19 @@ def setup_upv_position_calculation(
346346
upv_pos_sum[i].output >> getattr(upv, f"translate{axis}")
347347

348348

349-
def setup_visibility_and_matrix(root, upv, upvcrv):
349+
def setup_visibility_and_matrix(root, root_decompose, upv, upvcrv):
350350
"""
351351
Set up visibility and matrix connections.
352352
353353
Ensures the UPV node and curve correctly inherit the root node's transformation.
354354
355355
Args:
356356
root (PyNode): Root guide node
357+
root_decompose (PyNode): Decompose matris node from root
357358
upv (PyNode): Pole vector guide node
358359
upvcrv (PyNode): Pole vector display curve
359360
"""
360-
root.scale >> upv.scale
361+
root_decompose.outputScale >> upv.scale
361362
root.worldInverseMatrix[0] >> upv.offsetParentMatrix
362363
root.worldInverseMatrix[0] >> upvcrv.offsetParentMatrix
363364

@@ -394,4 +395,4 @@ def create_upv_system(root, elbow, wrist, eff, upvcrv, upv, float_value=0.5):
394395
elbow, upv, normalize_node, half_multiply_node, decompose_nodes
395396
)
396397

397-
setup_visibility_and_matrix(root, upv, upvcrv)
398+
setup_visibility_and_matrix(root, decompose_nodes[0], upv, upvcrv)

release/scripts/mgear/shifter_classic_components/arm_2jnt_01/guide.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def addObjects(self):
6161
"crv",
6262
[self.root, self.elbow, self.wrist, self.eff])
6363

64-
self.upv = self.addLoc("upv", self.root, vTemp)
64+
self.upv = self.addLoc("upv", self.root, vTemp, color=18, width=.3)
6565
self.upvcrv = self.addDispCurve("upvcrv", [self.elbow, self.upv])
6666
upv_visualizer.create_upv_system(
6767
self.root,
@@ -72,7 +72,7 @@ def addObjects(self):
7272
self.upv,
7373
float_value=0.5,
7474
)
75-
75+
7676
def addParameters(self):
7777
"""Add the configurations settings"""
7878

0 commit comments

Comments
 (0)