Merge pull request #143 from mgifford/copilot/review-github-actions-guidance

ci: add CI workflow, upgrade accessibility scanner to v3, remove redundant triggers

Author: mgifford

.github/workflows/ci.yml

@@ -0,0 +1,31 @@
+name: CI
+
+on:
+  pull_request:
+  push:
+    branches:
+      - main
+    paths-ignore:
+      - 'docs/**'
+
+permissions:
+  contents: read
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: '24'
+          cache: 'npm'
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Run tests
+        run: npm test

.github/workflows/daily-scan.yml

@@ -76,9 +76,6 @@ jobs:
       - name: Install dependencies
         run: npm ci
 
-      - name: Run tests
-        run: npm test
-
       - name: Run pipeline
         id: pipeline
         shell: bash

.github/workflows/scan-github-pages.yml

@@ -4,23 +4,27 @@ on:
   schedule:
     # Run on the first day of every month at 09:00 UTC
     - cron: '0 9 1 * *'
-  push:
-    branches:
-      - main
-    paths:
-      - 'docs/**'
   workflow_dispatch:
 
 permissions:
-  contents: write
+  contents: read
   issues: write
 
 jobs:
   scan-pages:
     runs-on: ubuntu-latest
     steps:
+      - name: Check for existing open accessibility issues
+        id: check_issues
+        env:
+          GH_TOKEN: ${{ github.token }}
+        run: |
+          COUNT=$(gh issue list --repo "$GITHUB_REPOSITORY" --label "accessibility" --state open --json number --jq '. | length')
+          echo "open_count=$COUNT" >> "$GITHUB_OUTPUT"
+
       - name: Scan GitHub Pages with axe-core
-        uses: github/accessibility-scanner@v2
+        if: steps.check_issues.outputs.open_count == '0'
+        uses: github/accessibility-scanner@v3
         with:
           urls: |
             https://mgifford.github.io/daily-dap/
@@ -29,3 +33,9 @@ jobs:
           token: ${{ github.token }}
           cache_key: daily-dap-github-pages
           skip_copilot_assignment: true
+
+      - name: Skip scan (open issues exist)
+        if: steps.check_issues.outputs.open_count != '0'
+        run: |
+          echo "Skipping scan: ${{ steps.check_issues.outputs.open_count }} open accessibility issue(s) already exist."
+          echo "Resolve open issues before a new scan is triggered."

README.md

@@ -125,6 +125,7 @@ This project is transparent about how AI tools have been used throughout its dev
 | Claude (Anthropic) | claude-sonnet-4-5 | Added required federal links checker (OMB M-17-06): detects Privacy Policy, Contact, and FOIA pages, inspired by the performance.gov website performance initiative |
 | Claude (Anthropic) | claude-sonnet-4.6 | Created STYLES.md: design and content standards aligned with CivicActions brand, colors, typography, and style guide conventions; added STYLES.md link to README documentation section |
 | Claude (Anthropic) | claude-sonnet-4.6 | CivicActions brand alignment: updated CSS color tokens (primary red #D83933, dark blue #162E51, secondary blue #1A4480), font stack (Public Sans), footer attribution, and tests in render-pages.js and index.html |
+| Claude (Anthropic) | claude-sonnet-4.6 | CI/CD improvements: added dedicated CI workflow for tests on PRs, upgraded accessibility scanner to v3, removed redundant push trigger from scan-github-pages workflow, added open-issues gate to prevent alert fatigue |
 
 ### Runtime operation