Refactor get_time function to simplify format specifier parsing and improve error handling (#7)

* Refactor get_time function to simplify format specifier parsing and improve error handling

* Add trunk ignore rules for specific directories and files; update test and header files to ignore clang-format

* Update trunk.yaml to ignore 'scripts/**' instead of 'workspaces/**' in linting configuration

Author: mguludag

.trunk/trunk.yaml

@@ -30,6 +30,19 @@ lint:
     - [email protected]
     - [email protected]
     - [email protected]
+
+  ignore:
+    - linters: [ALL]
+      paths:
+        - build/**
+        - tests/**
+        - scripts/**
+        - .vscode/**
+        - .devcontainer/**
+        - .github/**
+        - .trunk/**
+        - .git/**
+
 actions:
   disabled:
     - trunk-announce

include/mgutility/chrono/parse.hpp

@@ -25,6 +25,8 @@
 #ifndef MGUTILITY_CHRONO_PARSE_HPP
 #define MGUTILITY_CHRONO_PARSE_HPP
 
+// trunk-ignore-all(clang-format)
+
 #include "mgutility/std/charconv.hpp"
 #include "mgutility/std/string_view.hpp"
 
@@ -304,25 +306,13 @@ MGUTILITY_CNSTXPR auto parse_timezone_offset(detail::tm &result, string_view dat
 MGUTILITY_CNSTXPR auto get_time(detail::tm &result, string_view format,
                                 string_view date_str) -> std::errc {
   int32_t count{0};
-  uint32_t begin{0}, end{0};
+  std::size_t begin{0}, end{0};
 
   // Find the positions of format specifiers
-  for (auto i{0}; i < format.size(); ++i) {
-    switch (format[i]) {
-    case '{':
-      begin = i;
-      ++count;
-      break;
-    case '}':
-      end = i;
-      --count;
-      break;
-    }
-    if (begin < end)
-      break;
-    else if (count != 0 && end < begin)
-      break;
-  }
+  begin = format.find('{');
+  end = format.find('}');
+  if (begin == string_view::npos || end == string_view::npos || begin >= end)
+    return std::errc::invalid_argument;
 
   if (format[begin + 1] != ':' || (end - begin < 3 || count != 0))
     return std::errc::invalid_argument;
@@ -340,83 +330,44 @@ MGUTILITY_CNSTXPR auto get_time(detail::tm &result, string_view format,
       switch (format[i + 1]) {
       case 'Y': // Year with century (4 digits)
         error = parse_year(result, date_str, next);
-        if (error != std::errc{}) {
-          return error;
-        }
         break;
       case 'm': // Month (01-12)
         error = parse_month(result, date_str, next);
-        if (error != std::errc{}) {
-          return error;
-        }
         break;
       case 'd': // Day of the month (01-31)
         error = parse_day(result, date_str, next);
-        if (error != std::errc{}) {
-          return error;
-        }
         break;
       case 'F': { // Full date (YYYY-MM-DD)
         error = parse_year(result, date_str, next);
-        if (error != std::errc{}) {
-          return error;
-        }
         error = parse_month(result, date_str, next);
-        if (error != std::errc{}) {
-          return error;
-        }
         error = parse_day(result, date_str, next);
-        if (error != std::errc{}) {
-          return error;
-        }
       } break;
       case 'H': // Hour (00-23)
         error = parse_hour(result, date_str, next);
-        if (error != std::errc{}) {
-          return error;
-        }
         break;
       case 'M': // Minute (00-59)
         error = parse_minute(result, date_str, next);
-        if (error != std::errc{}) {
-          return error;
-        }
         break;
       case 'S': // Second (00-59)
         error = parse_second(result, date_str, next);
-        if (error != std::errc{}) {
-          return error;
-        }
         break;
       case 'T': { // Full time (HH:MM:SS)
         error = parse_hour(result, date_str, next);
-        if (error != std::errc{}) {
-          return error;
-        }
         error = parse_minute(result, date_str, next);
-        if (error != std::errc{}) {
-          return error;
-        }
         error = parse_second(result, date_str, next);
-        if (error != std::errc{}) {
-          return error;
-        }
       } break;
       case 'f': // Milliseconds (000-999)
         error = parse_fraction(result, date_str, next);
-        if (error != std::errc{}) {
-          return error;
-        }
         break;
       case 'z': { // Timezone offset (+/-HHMM)
         error = parse_timezone_offset(result, date_str, next);
-        if (error != std::errc{}) {
-          return error;
-        }
       } break;
       default:
         return std::errc::invalid_argument;
       }
+      if (error != std::errc{}) {
+        return error;
+      }
     } break;
     case ' ': // Space separator
     case '-': // Dash separator

include/mgutility/std/charconv.hpp

@@ -23,6 +23,9 @@ SOFTWARE.
 */
 #ifndef MGUTILITY_STD_CHARCONV_HPP
 #define MGUTILITY_STD_CHARCONV_HPP
+
+// trunk-ignore-all(clang-format)
+
 #include "mgutility/_common/definitions.hpp"
 #include <system_error>
 

tests/test_chrono_parse.cpp

@@ -3,6 +3,8 @@
 #include "mgutility/chrono/parse.hpp"
 #include <chrono>
 
+// trunk-ignore-all(clang-format)
+
 template <typename T>
 auto to_milliseconds(T time_point) -> std::chrono::milliseconds {
   return std::chrono::duration_cast<std::chrono::milliseconds>(time_point.time_since_epoch());