Skip to content

Conversation

@dra
Copy link
Collaborator

@dra dra commented Mar 12, 2019

No description provided.

@mhoogveld
Copy link
Owner

Isn't this the same as setting the warning threshold?
If the amount is below the warning level, everything is considered OK.

@dra
Copy link
Collaborator Author

dra commented Mar 13, 2019

Isn't this the same as setting the warning threshold?
If the amount is below the warning level, everything is considered OK.

Yes, but we need this to be defined by argument passing, as we share the same php across multiple NAS systems, checked with different parameters. So we need to set the ignorable sector count for each system.

@mhoogveld
Copy link
Owner

The addition is in line with the implementation of --ignore-bad-sectors, but wouldn't adding parameters to adjust the default warning and critical levels be better?
There would be only two thresholds ('warn' and 'crit') instead of three (an additional 'ignore' level).
That would keep things more straight forward without losing any functionality.

The same thing would apply to --ignore-bad-sectors. The parameter could be deprecated and aliased by --bad-sector-warning for a while before being removed.

@mhoogveld
Copy link
Owner

How does the branch pending-sect-thresholds work for you?
https://github.com/mhoogveld/check_thecus_nas/tree/pending-sect-thresholds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants